Customer Home: Add MC stats and tracks events to all the links #35563
Conversation
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~375 bytes added 📈 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This change adds Tracks events and bumps MC stats for each link on the page. It passes whether the site is using a static homepage to the Tracks events, because we are planning on showing different links to people based on this option, and we may want to segment the data by it.
pablinos
force-pushed
the
add/customer-home-analytics
branch
from
ea00f86 to
be85e79
Compare
When a site sets the option to display posts on the homepage, the buttons to edit the homepage are not appropriate. This change checks the value of the option for the site and swaps the two of the buttons, so the user additionally has a link to manage their comments.
Customer Home: Update links when the site displays posts on the homepage
| page( `/post/${ siteSlug }` ); | ||
| } } | ||
| > | ||
| { translate( 'Write Blog Post' ) } |
There was a problem hiding this comment.
Hi! I've found a possible matching string that has already been translated 4 times:
translate( 'Write blog post' ) ES Score: 9
See 1 additional suggestion in the PR translation status page
Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).
| trackAction( 'my_site', 'manage_comments' ); | ||
| page( `/comments/${ siteSlug }` ); | ||
| } } | ||
| label={ translate( 'Manage comments' ) } |
There was a problem hiding this comment.
Hi! I've found a possible matching string that has already been translated 140 times:
translate( 'Manage Comments' ) ES Score: 9
Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).
pablinos
added
the
[Status] Needs Review
matticbot
removed
the
[Status] Needs Review
Changes proposed in this Pull Request
This change adds Tracks events and bumps MC stats for each link on the
page. It passes whether the site is using a static homepage to the
Tracks events, because we are planning on showing different links to
people based on this option, and we may want to segment the data by it.
Testing instructions
Turn on debug for analytics using:
localStorage.setItem('debug', "calypso:analytics:mc,calypso:analytics:tracks")in your browser console.
Click on the various links on the customer home page and check the logs in the console. You should see events being tracked of the form