Skip to content

Environment badge: only display bar when mouse is exactly over the badge #35489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2019
Merged

Environment badge: only display bar when mouse is exactly over the badge #35489

merged 1 commit into from
Aug 20, 2019

Conversation

eliorivero
Copy link
Contributor

@eliorivero eliorivero commented Aug 16, 2019 •
edited
Loading

This is so the bar is not displayed when the user hovers near the badge. One issue with this was for example that the OK button to consent to cookies is in the footer, and the badge overlapped it, so whenever someone wanted to click the OK button, the bar was unfolded.

Screen Shot 2019-08-16 at 15 49 15

Changes proposed in this Pull Request

  • remove padding so the bar isn't displayed when the mouse is near the badge and so it overlaps other controls as less as possible

Testing instructions

  • check that it works as before, and that if the mouse is near the badge but not exactly over the badge, the control bar is not displayed

@eliorivero
Environment badge: only display bar when user rolls the mouse exactly…
24396a7 
… over the badge

This is so the bar is not displayed when the user hovers near the badge. One issue with this was for example that the OK button to consent to cookies is in the footer, and the badge overlapped it, so whenever someone wanted to click the OK button, the bar was unfolded.
@eliorivero eliorivero added [Type] Bug When a feature is broken and / or not performing as intended [Pri] Low Address when resources are available. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Aug 16, 2019
@eliorivero eliorivero self-assigned this Aug 16, 2019
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/environment-badge

@eliorivero eliorivero requested a review from flootr August 16, 2019 18:54
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Aurorum
Aurorum approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@Aurorum Aurorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Screenshot 2019-08-16 at 20 32 20

flootr
flootr approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@flootr flootr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@eliorivero eliorivero merged commit 92d6cf8 into master Aug 20, 2019
@eliorivero eliorivero deleted the update/environment-badge branch August 20, 2019 14:02
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@flootr flootr flootr approved these changes

@Aurorum Aurorum Aurorum approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@eliorivero eliorivero

Labels
[Pri] Low Address when resources are available. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eliorivero @matticbot @flootr @Aurorum