Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Home: add HotJar tracking #35479

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Home: add HotJar tracking #35479

merged 1 commit into from
Aug 20, 2019

Conversation

eliorivero
Copy link
Contributor

Changes proposed in this Pull Request

  • add HotJar tracking

Testing instructions

  • let's check that HotJar is working

Fixes #35478

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/home-hotjar

@eliorivero eliorivero self-assigned this Aug 16, 2019
@eliorivero eliorivero added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] My Home The main dashboard for managing a WordPress.com site. labels Aug 16, 2019
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~178 bytes added 📈 [gzipped])

name  parsed_size           gzip_size
home       +709 B  (+0.3%)     +178 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@eliorivero eliorivero requested a review from sirreal August 16, 2019 18:37
sirreal
sirreal approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested but the code looks correct.

@eliorivero eliorivero merged commit 806e8bf into master Aug 20, 2019
@eliorivero eliorivero deleted the add/home-hotjar branch August 20, 2019 14:13
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 20, 2019
@jsnajdr jsnajdr mentioned this pull request Apr 22, 2021
Merged
@aneeshd16 aneeshd16 mentioned this pull request Feb 6, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirreal sirreal sirreal approved these changes

Assignees

@eliorivero eliorivero

Labels
[Feature] My Home The main dashboard for managing a WordPress.com site. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HotJar JS snippet to page
3 participants
@eliorivero @matticbot @sirreal