Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importers: restore correct width of importer progress bar #31428

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Importers: restore correct width of importer progress bar #31428

merged 1 commit into from
Mar 13, 2019

Conversation

andfinally
Copy link
Contributor

Changes proposed in this Pull Request

  • It looks like a recent change to the app CSS - perhaps in the order of inclusion of stylesheets - has made the upload/import progress bars too wide.

image

image

  • This PR restores the original width by increasing the specificity of the rule.

Testing instructions

  • Perform a test WordPress import in Calypso. The upload progress bar and import progress bar should both be 80% of the width of their containing pane as shown.

image

Related comment

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/importer-ui-fixes-progress-bar

bisko
bisko approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@bisko bisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bisko bisko added [Type] Bug When a feature is broken and / or not performing as intended Import [Status] Ready to Merge labels Mar 13, 2019
@andfinally andfinally merged commit ef24b35 into master Mar 13, 2019
@spen
Copy link
Contributor

spen commented Mar 15, 2019

Nice! Thanks for this @andfinally 👌

@spen spen deleted the fix/importer-ui-fixes-progress-bar branch March 15, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bisko bisko bisko approved these changes

Assignees

@andfinally andfinally

Labels
Import [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andfinally @matticbot @spen @bisko