Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove z-index from the eCommerce plan nudge & fix warning #30910

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

justinshreve
Copy link
Contributor

This tiny PR removes an unnecessary z-index rule on the eCommerce plan nudge. It was causing a warning on npm start.

*WARNING: No layer found for `.ecommerce-manage-nudge__close-icon` of `[root, .ecommerce-manage-nudge__close-icon]` in $z-layers map. Property omitted.
         on line 306 of assets/stylesheets/shared/functions/_z-index.scss, in function `map-deep-get`
         from line 315 of assets/stylesheets/shared/functions/_z-index.scss, in function `z-index`
         from line 17 of stdin
*

The rule was included when basing the nudge on previous blocks, but the class was not added to the z-layers variable: https://github.com/Automattic/wp-calypso/blob/master/docs/coding-guidelines/css.md#z-index. The rule doesn't seem necessary so I just removed it.

Testing instructions

  • npm start and make sure no WARNING appears. It would show up right after Getting bundles ready, hold on....
  • Checkout the nudge on an eCommerce plan and see that the close button displays.

@justinshreve justinshreve added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 20, 2019
@justinshreve justinshreve self-assigned this Feb 20, 2019
@justinshreve justinshreve requested a review from timmyc February 20, 2019 17:47
@matticbot
Copy link
Contributor

Copy link
Contributor

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmyc timmyc added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 20, 2019
@justinshreve justinshreve merged commit c782ff5 into master Feb 20, 2019
@justinshreve justinshreve deleted the fix/ecommerce-nudge-z-index branch February 20, 2019 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants