Remove z-index from the eCommerce plan nudge & fix warning #30910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny PR removes an unnecessary
z-index
rule on the eCommerce plan nudge. It was causing a warning onnpm start
.The rule was included when basing the nudge on previous blocks, but the class was not added to the z-layers variable: https://github.com/Automattic/wp-calypso/blob/master/docs/coding-guidelines/css.md#z-index. The rule doesn't seem necessary so I just removed it.
Testing instructions
npm start
and make sure noWARNING
appears. It would show up right afterGetting bundles ready, hold on...
.