Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store: Add "Powered by WooCommerce" to the footer #23463

Merged
merged 2 commits into from
Mar 21, 2018

Conversation

justinshreve
Copy link
Contributor

@justinshreve justinshreve commented Mar 20, 2018

This PR added a "Powered by WooCommerce" credit to the bottom of all store pages. I named the component to match the Jetpack one, in case we end up moving these components out of the extension directory in the future.

Fixes #22662.
Closes #21376.

screen shot 2018-03-20 at 1 20 57 pm

To Test:

  • Look at any store page and make sure that the footer shows up.

@justinshreve justinshreve added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR Store labels Mar 20, 2018
@justinshreve justinshreve self-assigned this Mar 20, 2018
@matticbot
Copy link
Contributor

@justinshreve justinshreve requested review from jameskoster, kellychoffman and a team March 20, 2018 20:27
Copy link
Contributor

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out on a site with the setup wizard and normal store screens. Looking great to me!

);
};

WooCommerceLogo.propTypes = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing I could see changing here is to have some default propTypes so these aren't required.

Copy link
Member

@kellychoffman kellychoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it!!! :shipit:

@timmyc timmyc added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 21, 2018
@justinshreve justinshreve merged commit e3e02c7 into master Mar 21, 2018
@matticbot matticbot removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Ready to Merge labels Mar 21, 2018
@justinshreve justinshreve deleted the add/woocommerce-powered-by branch May 11, 2018 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants