Store: Add footer text setting to the email settings page #23091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8ci18n
reviewed
Mar 7, 2018
| { | ||
| field: 'email', | ||
| option: 'woocommerce_email_footer_text', | ||
| title: translate( 'Footer text' ), |
There was a problem hiding this comment.
Hi! I've found a possible matching string that has already been translated 9 times:
translate( 'Footer Text' ) ES Score: 12
Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).
emdashcodes
added
[Status] Needs Review
emdashcodes
force-pushed
the
add/store-email-footer-text
branch
from
95feeeb to
e9e0f6e
Compare
timmyc
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an email footer text setting to the email settings page, now that we removed the override filter from wc-calypso-bridge (see Automattic/wc-calypso-bridge#37 (comment)).
New stores will default to having the dynamic site title as the email footer, but older stores may have a stale value (i.e. the actual text "Site Title" which the filter was designed to fix). Adding the setting here will allow users to fix this on their own without having to dig through wp-admin to fix it.
To Test:
http://calypso.localhost:3000/store/settings/email/:siteFooter textsetting and a value is present