Store: Fix Apple Pay Option

[justinshreve]

Apple Pay support still exists in the latest Stripe Gateway plugin, but has been renamed to "Payment Request Buttons" which also includes Chrome Pay support.

This updates the option we are saving, as well as the text to reflect that both will be enabled (which matches what wp-admin does).

It also introduces a temporary API fix that is causing Stripe saves to fail for new stores (which was also reported on our P2 this morning). The value 'default' gets pushed back for one of the settings that is a dropdown and only has three valid options. This one forces a default. I opened an issue at woocommerce/woocommerce-gateway-stripe#459. I'm not sure if we want to offer a drop down option for this either or just stick with the default the gateway sets. I've left it out for now but we can add it in a follow-up.

To Test:

• Make sure you can open up the stripe dialog both in 'key' mode and 'connect' mode.
• Make sure you can toggle the value of the button.
• Make sure your values save.

[timmyc]

I'm not able to change any of my Stripe settings using this branch right now - the API is returning the following error message:

"body":{"error":"rest_setting_value_invalid","message":"An invalid setting value was passed."}}

[allendav]

If a site

• had Stripe 3.2.3 up and running (and set up)
• updated to 4.x
• you try to "manage" it from calypso (without ever saving settings in wp-admin since the update)
• calypso https://public-api.wordpress.com/rest/v1.1/jetpack-blogs/131052677/rest-api/?http_envelope=1&path=%2Fwc%2Fv3%2Fpayment_gateways%26_method%3Dget&json=true GETs invalid values for payment_request_button_type, payment_request_button_theme and payment_request_button_height (empty values)

• when you try to save a change (e.g. to the descriptor) , it borks because of the empty values

edit: Workaround: Save settings once in wp-admin, then force refresh calypso

[justinshreve]

@allendav Thank you so much for tracking it down that it was those other options. I made a fix that should set these values if they are empty. See d3b08f3.

You should now be able to save if you have borked settings. I made a little plugin to make it help mess up your settings so you can test the fix along with the rest of this branch.

To Test:

• Upload this gist (https://gist.github.com/justinshreve/ca158b7767259de93494e0919eae146f) as a plugin to your AT site and activate it.
• Visit https://your-at-site.blog/?isotope=break-stripe-settings
• Load up this branch and go to http://calypso.localhost:3000/store/settings/justin-devstore-at.blog
• Open devtools and go to the network tab. Search for payment_gateways and make sure the following values are blank:
  • payment_request_button_type
  • payment_request_button_theme
  • payment_request_button_height
• Select the manage button for stripe and make a change (like the descriptor field)
• Hit done.
• Hit save.
• Hopefully see a success message!
• Now Test the original testing steps for this PR.

[timmyc]

With the latest updates all is looking good and testing well on the two sites I was experiencing issues with yesterday. Thanks for the work on this @allendav and @justinshreve