Me: Use Redux analytics instead of eventRecorder in Security2faSetupBackupCodes

[tyxla]

This PR refactors Security2faSetupBackupCodes to:

• Use Redux analytics instead of eventRecorder.
• Remove all mixins, specifically eventRecorder.
• Convert from createReactClass to a React.Component.
• Remove some unnecessary debug code.
• Sort some imports 🔤 .
• Remove var usages in favor of const/let.

This PR should not introduce any visual changes.

Part of #20053.

To test:

• Checkout this branch
• Go to http://calypso.localhost:3000/me/security/two-step
• Disable two step auth if it's enabled.
• Apply the following diff to your Calypso (see below)
• Refresh the page.
• Start the two-step auth setup process.
• On the last step where the codes are generated, verify the right analytics events are tracked when clicking the support link on the failure screen.
• Verify everything else in the backup codes / two factor auth process works like it did before.

Diff to make backup code generation fail:

diff --git a/client/lib/two-step-authorization/index.js b/client/lib/two-step-authorization/index.js
index cc0e2732a7..af89d9dbc6 100644
--- a/client/lib/two-step-authorization/index.js
+++ b/client/lib/two-step-authorization/index.js
@@ -153,6 +153,8 @@ TwoStepAuthorization.prototype.sendSMSCode = function( callback ) {
  * Fetches a new set of backup codes by calling /me/two-step/backup-codes/new
  */
 TwoStepAuthorization.prototype.backupCodes = function( callback ) {
+       callback( 'Some error' );
+       return;
        wpcom.me().backupCodes(
                function( error, data ) {
                        if ( error ) {

[matticbot]

Test live: https://calypso.live/?branch=cleanup/event-recorder-security-2fa-setup-backup-codes

[ockham]

• Force a failure of backup codes retrieval (you can do it quickly in TwoStepAuthorization.prototype.backupCodes).

Uh, how specifically? My attempts so far didn't get me anywhere 😁

[tyxla]

@ockham I realize those testing instructions are a total mess 😉 Sorry about that.

I've updated them a bit, please ping me if you need details when you have a minute to test this one. Thanks!

[ockham]

Thanks for the updated instructions! Confirmed to work fine now. 👍