Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier webpack config #19584

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Prettier webpack config #19584

merged 1 commit into from
Nov 16, 2017

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Nov 7, 2017 •
edited
Loading

Why can't our configs be pretty 💅

This is just running prettier on webpack.config[.node].js.

@sirreal sirreal added [Pri] Low Address when resources are available. [Type] Janitorial labels Nov 7, 2017
@sirreal sirreal self-assigned this Nov 7, 2017
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/prettier-webpack-config

@sirreal sirreal added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 7, 2017
@sirreal sirreal added the Build label Nov 8, 2017
@sirreal sirreal force-pushed the update/prettier-webpack-config branch from 0e2c43e to 88c61c8 Compare November 8, 2017 09:16
gwwar
gwwar approved these changes Nov 16, 2017
View reviewed changes
Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of configs being ✨

samouri
samouri approved these changes Nov 16, 2017
View reviewed changes
Copy link
Contributor

@samouri samouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lost track of this 😲

@alisterscott
Copy link
Contributor

Looks good to me - passes the e2e tests

@alisterscott alisterscott added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 16, 2017
@sirreal sirreal merged commit 95ab5b4 into master Nov 16, 2017
@sirreal
Copy link
Member Author

sirreal commented Nov 16, 2017

😍 Thanks folks!

@sirreal sirreal deleted the update/prettier-webpack-config branch November 16, 2017 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samouri samouri samouri approved these changes

@gwwar gwwar gwwar approved these changes

@blowery blowery Awaiting requested review from blowery

@DanReyLop DanReyLop Awaiting requested review from DanReyLop

Assignees

@sirreal sirreal

Labels
Build [Pri] Low Address when resources are available. [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sirreal @matticbot @alisterscott @gwwar @samouri