Fix Google button disabled after first display #19357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the case where the Google APIs client library is already loaded and initialized when the Google button is mounted again. This was failing because according to the documentation, the gapi.client.init function can be run multiple times, but the scope and clientId parameters cannot be provided multiple times, since the gapi.auth2 module can only be initialized once. See https://developers.google.com/api-client-library/javascript/reference/referencedocs#gapiclientinitargs for more information.
stephanethomas
added
Login
[Feature] Signup & Account Creation
stephanethomas
commented
Oct 31, 2017
|
|
||
| return gapi; // don't try to return googleAuth here, it's a thenable but not a valid promise | ||
| } ) | ||
| ) |
There was a problem hiding this comment.
The whole approach for fixing that issue was suggested here.
|
Works as described, code looks good 👍 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #19289 to make sure the
Continue with Googlebutton on theLoginpage and on theUserstep of the signup flow is always enabled. Previously it would be enabled only the first time it would be displayed.Login
Signup
Testing instructions
git checkout fix/google-buttonand start your server, or open a live branchSignuppage in an incognito tabContinue With Googlebutton is enabledAlready have a WordPress.com account? Log in now.link in the footerContinue With Googlebutton on theLoginpage is enabledYou should try again but starting the flow from the
Loginpage this time.Reviews