Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store: Add a setting for the new order notification. #19196

Merged
merged 1 commit into from
Oct 31, 2017

Conversation

justinshreve
Copy link
Contributor

@justinshreve justinshreve commented Oct 26, 2017

This PR adds a new setting for Store on .com sites, that allow them to disable the 'New order' notification.

See #16181.

screen shot 2017-10-26 at 12 43 59 pm

To Test:

  • Apply the patch from D7802-code and follow the testing steps there.
  • Apply this branch, and go to your notification settings.
  • Select a normal WordPress.com blog. Make sure that the 'New order' option doesn't display.
  • Select a normal Jetpack blog if you have one, Make sure that the 'New order' option doesn't display.
  • Select one of your AT Stores. Verify that you see a 'New order' option.
  • Toggle the option, and place a new order on your test site from D7802-code. Make sure you do not receive a notification.

@matticbot
Copy link
Contributor

@justinshreve justinshreve changed the title Store:Add a setting for the new order notification. Store: Add a setting for the new order notification. Oct 26, 2017
@justinshreve justinshreve requested a review from timmyc October 26, 2017 19:45
@justinshreve justinshreve self-assigned this Oct 26, 2017
@justinshreve justinshreve added Store [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 26, 2017
@justinshreve
Copy link
Contributor Author

One thing that this doesn't do is offer an option to disable the WooCommerce email. I don't consider that a blocker for this notification though. Hooking that up here is going to require a bit more thought and work since the notification settings are stored on WordPress.com, and emails are built and sent from the end AT site.

Copy link
Contributor

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is looking good to me here. Verified the setting only shows when it should, and updates/persists as expected.

Per our DM, I configured my JETPACK__API_BASE and updated my sandbox with the latest diff, but did not receive order notifications as expected. I'll keep testing it out and review the phabricator diff next, but this is looking good to go here.

@justinshreve justinshreve added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 31, 2017
@justinshreve justinshreve merged commit ed8541e into master Oct 31, 2017
rclations pushed a commit to rclations/wp-calypso that referenced this pull request Nov 15, 2017
@justinshreve justinshreve deleted the add/store-order-notification-toggle branch January 8, 2018 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants