Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing labels in iOS & Android #19012

Merged
merged 2 commits into from
Oct 20, 2017
Merged

Fix printing labels in iOS & Android #19012

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce8587f
Make label printing work in iOS (same logic changes as in WooCommerce…
Oct 19, 2017
066c029
Fix label printing in Android (it purges revoked URLs instantly)
Oct 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix label printing in Android (it purges revoked URLs instantly)
  • Loading branch information
Daniel Rey Lopez committed Oct 19, 2017
commit 066c029a2d830db14f5dfe954d62d67d5e22eca4
2 changes: 1 addition & 1 deletion client/extensions/woocommerce/woocommerce-services/lib/utils/print-document.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export default ( { b64Content, mimeType }, fileName ) => {
// If browser doesn't support PDFs at all, this will trigger the "Download" pop-up.
// No need to wait for the iframe to load, it will never finish.
loadDocumentInFrame( blobUrl );
URL.revokeObjectURL( blobUrl );
setTimeout( () => URL.revokeObjectURL( blobUrl ), 0 );
return Promise.resolve();
}
};