Site Setting Exporter: fix action-name in reducer #18842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
added
[Pri] BLOCKER
|
Oh, I’m surprised that hasn’t caused problems until now, good catch. Looks good 👍 |
|
@jordwest: do you know what proper testing instructions would be? I'd hate to add a bug when "fixing" the issue but I also don't know how to test this. |
|
@samouri: Essentially just go to Site Settings > Export and make sure the advanced settings are displayed and the lists are populated. It's also worth checking the failure case when the server responds with some error. I'm guessing that case might have already been broken before (and fixed by) this PR, but happens rarely enough that it wasn't picked up. (I can't test this as I no longer have access to the backend) |
matticbot
removed
the
[Status] Needs Review
|
Thank you for the help @jordwest! |
llzes
pushed a commit
to llzes/wp-calypso
that referenced
this pull request
Oct 22, 2017
* Remove empty stylesheets * Add script that analyzes CSS bundle and ranks sections by size * CSS Analyzer: Handles missing stylesheets This also reorganizes code. * CSS Analyzer: Add interactive interface for consuming results This adds a feature similar to ncdu. See https://dev.yorhel.nl/ncdu for reference. * Editor: Don't error out when attempting to decode query arguments in images (Automattic#18770) * Editor: Wrap lines in EditorDiffViewer (Automattic#18786) * Image Editor: Add test coverage for utils * Image Editor: Correctly refer to AspectRatios.FREE in utils * Image Editor: Better syntax for checking inclusion in utils * Image Editor: Replace context usage in utils test file * Reader: add Conversations empty state illustration (Automattic#18621) * Add empty state illustration * Add component for Conversations empty state * Add classname * Don't render intro banner on empty stream * Adjust width and position * Remove TaxJar install upon Store setup, as WCS 1.8 includes this functionality (Automattic#18787) * Comments: add quick actions to the comments list view (Automattic#18657) * Blocks: De-dupe disconnectJetpack() method (Automattic#18764) This removes the duplicated `disconnectJetpack()` method from both * `my-sites/site-settings/manage-connection/disconnect-site-link.jsx` and * `my-sites/plugins/disconnect-jetpack/disconnect-jetpack-button.jsx` and moves it to `blocks/disconnect-jetpack-dialog/index.jsx` (which both other files use) instead, where I think it belongs. The immediate rationale is that I'm going to need `blocks/disconnect-jetpack-dialog` for Automattic#18039, and I don't want to triplicate that code. The method in question calls a number of Redux actions, which is something that can easily be solved by adding those to the block's `mapDispatchToProps` call. The little state handling it does (hiding the dialog) can be abstracted by simply invoking the `onClose` prop. * Reader Conversations: remove show all (Automattic#18766) * Reader Conversations: remove show all * remove more traces of showall and make cursor behavior better * Fix caterpillar count * Add space * Remove unnecessary class * Use div instead of card * disable Yandex ad tracking (Automattic#18792) * Stats: adds a property `last_pageview_path` to the Tracks page view event to better understand user behavior * Reader Tracks: add tracking to clicking comment timestamp (permalink) * Sidebar: removes feature flag checks for Media and Comments (Automattic#18791) * comment permalinks open in new tab * pun the field * Comments: adds the comment date to the collapsed view (Automattic#18624) * Try: Remove redundant preconnect * Try: Preload CSS files to increase asset priority * Webpack: fix react-hot-loader configuration (Automattic#18771) * Store orders: add email validation to the customer edit dialog (Automattic#18763) * Try: Split script and stylesheet preloads * Updated the list of suggested themes. Fixes Automattic#18798 * Jetpack Connect: Change help button copy for connected site plans (Automattic#18775) * Jetpack Connect: Allow for custom copy in Happychat button * Jetpack Connect: Allow for custom copy in Help button * Jetpack Connect: Change help button copy in connected site plans * Jetpack Connect: Rename help button text prop to label * Query Manager: Use static methods (Automattic#17990) * Make QueryKey, DEFAULT_QUERY static class properties * Rename QueryManager.DEFAULT_QUERY to DefaultQuery * Make QueryManager methods static: * compare * mergeItem * sort * Update tests accordingly * Consolidate state shape for happychat.user (Automattic#18739) * State: extract happychat.user reducer * State: extract selectors related to happychat.user Props to @unDemian @omarjackman @southp for reviews * Consolidate state shape for happychat.connection (Automattic#18699) * Remove clearChatMessage unused action * State: extract happychat.connection from happychat * Extract HAPPYCHAT_CONNECTION_STATUS_* constants * Add tests Props to @unDemian and @omarjackman for reviews * DisconnectJetpackDialog: Factor out DisconnectJetpack Component (Automattic#18794) This is needed for Automattic#18796, where we're going to display the contents of the `DisconnectJetpackDialog`, but as part of a multi-step flow, not a dialog. The structure of `DisconnectJetpackDialog` fortunately lends itself to splitting into a component proper, and a `Dialog` wrapper. Note that props have been re-arranged a little: E.g. the concept of an `onClose` prop doesn't make sense for the component, so we're passing `onDisconnectClick` and `onStayConnectedClick` instead. The Dialog OTOH continues to use an `onClose` prop (and sets both `onDisconnectClick` and `onStayConnectedClick` to `onClose`). Also, add a few missing propTypes, and simplify `planClass` logic. * Jetpack Config: Add start & finish tracks events * Editor: Update the Add button in the HTML Editor toolbar (Automattic#18773) Combine "insert content" and "insert special" into one menu item in the HTML Editor toolbar. All the options previously available in the "insert special" menu are now accessible from one single button. * Switch to using status helper function, rather than hardcoding statuses in component (Automattic#18747) * Store orders: Set initial refund value in modal (Automattic#18728) * Move refund calculation into the dialog, so that we can set an initial refund value when the dialog is opened. Fixes Automattic#18673 * Set the refund value back to the initial value when the dialog is toggled * Only reset the refundTotal when the dialog is opening * Atomic Store: enable the signup flow on wpcalypso and horizon (Automattic#18820) * Editor: Revisions: Add title diffing (Automattic#18788) * fix paragraphs by wrapping content in pre * add diffing for rvision title * extract change rendering logic * extract diff highlighter, more explicit proptypes * test decription * separate format declarations * format of format * Reader: fix convos to display just-added comments (Automattic#18806) * Reader: fix convos to display comments newly added comments * Display placeholders * Editor: Revert insert content button back to default tooltip (Automattic#18802) * Add currency-formatting helper function to round to currency-specific precision (no fraction cents in USD, no fraction yen in JPY, etc) (Automattic#18826) * Editor Header: Edit CSS to allow for additional content items * Editor Header: Refactor status rendering, only render if has content * MailChimp integration query components. (Automattic#18751) * Comments: restores the click functionality on the comment header checkbox (Automattic#18848) * MailChimp getting started UI view. (Automattic#18779) * Activity Log: remove unnecessary activityLogError action (Automattic#18679) * Add log into MailChimp step. (Automattic#18783) * MailChimp API key input. (Automattic#18789) * Editor: Ground control - Add history button * Editor: Ground control - Add history button to header * Editor: Ground control - Only show history button if there are revisions * Editor: Ground control - Only show history button if post revisions are enabled * Toggle the showing state of the sidebar when clicking `History` * Editor: Ground control - Apply prettier formatting * Atomic Store: show proper checkout-thank-you to new users (Automattic#18829) * Devdocs: Fix some blocks example (Automattic#18765) Fix Input Chrono, DropZone, PostSchedule, and ConversationCommentList examples. * MailChimp store info card. (Automattic#18797) * MailChimp newsletter settings UI component. (Automattic#18804) * Add MailChimp to plugins installation process. (Automattic#18777) * Fix devdocs for ConversationCommentList (Automattic#18810) * added shim of jitms * added data layer * checkpoint - jitms work * Add some documentation to the data layer piece with tests * transform jitm component into an absolute pure component * Add readme * Create a selector for jitms * jam session with @dmsnell * pass on site id * Clean up selectors and reducers to have a snappy user experience * fix eslint error * Use jetpack proxy * add jetpack proxy schema and dubugging stops * fix api response * update tests to reflect some optimizations * Move config check up to parent * turn on prettier, refactor tests * Reader Devdocs: fix conversations list component (Automattic#18872) * NitPick: Rename isSaveEnabled to isSaveAvailable * Atomic Store: Remove wp.com domains from Domains signup step (Automattic#18869) * use flowName to exclude wp.com domains in atomic-store * use `getDesignType` select to detect atomic store flow * Reader Tags: remove recs (Automattic#18844) * Magic Logic: interstitial page constant missing (Automattic#18840) * Bump webpack and shrinkwrap (Automattic#18767) * Bump webpack and shrinkwrap * remove ajv deps * reshrinkwrap * Store: Fix error and propType warning in Packages. (Automattic#18836) * Restore GA action (Automattic#18876) Fix disconnection from site selector. * Disable "wpcom-user-bootstrap" until it works correctly with GeoIP. (Automattic#17849) * Disable "pwcom-user-bootstrap" until it works correctly with GeoIP. * Keep `wpcom-user-bootstrap` in production for now. * Reader: Release conversations to staging, expand flags Releases Reader Conversations to staging and expands the usage of the feature flag to cover the routes used. * WooCommerce - Copied the Shipping Label components from WCS Resolve some QueryLabels dependent module Copied tree.js module from WooCommerce Services Updated shrinkwrap with reselect (added TODOs to remove it) and libphonenumber-js Made the QueryLabels component work * WooCommerce Labels - Moved action types to the shared action-types.js (Automattic#17735) * Moved action types to the shared action-types.js * Removed duplicate LABELs from some type names * WooCommerce - Copied the *updated* Shipping Label components from WCS (Automattic#17751) Copied missing label purchase polling code * WooCommerce Labels - fix the build errors (Automattic#17755) * Fixed the PropTypes imports * Conditionally rendering the labels UI in order details * Fixed some of the imports * Copied over ActionButtons component * Fixed ActionButtons imports * Fixed /lib imports * Fixed build errors for missing components * Fixed the rest of the imports and copied over missing components * Tweaked the main label view and purchase label to work * Merged the selectors files, removed reselect usages * Minor fix * Added siteId and orderId to all action definitions * Made the modal render * Address normalization fix * Made the packages step work * Tweaked the rates step * Made the label items not throw errors * Added CSS import for the label * Fixed print url and cross-browser warnings * Style fixes * Fixed the spinners * Replaced formatDate with moment's format method * Fixed a typo in CSS class selector * Made the refund and reprint dialogs render * Changed the order of orderId, siteId arguments in actions to match selectors * WooCommerce Services - fixed lodash imports (Automattic#18178) * WooCommerce Services - fixed lodash imports * Added a missing round() precision argument * WooCommerce - fixed shipping labels unit tests (Automattic#18183) * Fixed unit tests * Using nock to prevent API requests being sent from the tests * Labels - fixed the code to adhere to the Calypso standards Fixed the class names Fixed the i18n imports Removed usages of GlobalNotices Fixed wrong placement of the keyedReducer import * Labels - added selectors for the order activity log Removed "return false" from the getOrderNotes selector, return empty list instead. Added selectors for the Order Activity Log, that merges order notes with label events Use the getLabels selector (copied from https://github.com/Automattic/wp-calypso/pull/17757/files#diff-111b3d32a30c9153b2b5a2bf4fb01035R29 ). Added documentation Fixed wrong property to get the refundable amount Added tests Fixed the labelIndex calculation, since the server returns the labels in inverse chronological order. Added extra props to the LABEL_PURCHASED event and updated the tests for them. * Implement PDF printing for WCS labels (Automattic#18718) * Remove the "preview PDF URL" logic since it's not used in Calypso (and will be retired from WCS) * Implemented PDF printing in Calypso, including IE/Edge shenanigans * Fix reducer, remove console logging * Fixed printing in Firefox. * Close the Reprint dialog after showing the PDF * Added required args to clearAvailableRates call * WooCommerce - Added a "Print label" button to the order page (Automattic#18281) * Showing the print label button in the order fulfillment section * Added boolean flags fro fulfilling the order and emailing the details * Marking the order as complete and sending a note to the customer * Conditionally changing the messages depending on the labels status * Fix order item margins * Moved the fulfill button out of the popover menu * Use `button` prop instead of `ActionButtons` component To fix scrolling and fix the buttons at the bottom of the modal * Fix modal scrolling * label printing modal sidebar / content spacing * Move status icon to card summary The fixes the awkward space on the left of the card title when no icon is present * label printing modal sidebar styling * packages styling * Using the input with suffixes for package weights * status icon when there's no status * remove last card bottom margin * Fixed the buttons order, a React warning, and purchase button state * Move success/warning/error icons so they appear after the summary * Adjusted the dialog height * Not rendering the labels button when no payment method selected * Rendering the regular fulfill button in a popover menu * Update weight placeholder - Text wasn’t entirely visible (input too small) rendering it useless - Words as placeholder suggest the actual content should be text rather than numeric * Made notices appear on top of the dialog * Unescaping address fields * Made the "no payment method" logic clearer * Using decodeEntities to unescape HTML in address fields * Respecting the enabled state of labels in the shipping settings * Handling various json error formats in api * WooCommerce Services - Readded the labels action log (Automattic#18824) * Labels - final fixes Tweaked the logic to show the labels when no payment method is selected Fix update handler for paper size dropdown Folding the address step on trivial normalization Expanding the next step after address confirmation, code cleanup Fixed the product linkw Removed redundant code Removed the obsolete packages warning Fixed the broken link on item move modal * Notices: Import `impure-lodash` to enhance testability (Automattic#18849) `createNotice()` relies on `lodash.uniqueId()` for generating ids for created notices in Calypso which calling functions can use to later refer to those, cancel them, or update them. Sadly, because `uniqueId()` has global shared-state it can be difficult to write tests for its behavior as it's not pure. We can't easily mock out specific **lodash** methods either because of some internals on how it works. Therefore we created `impure-lodash` as a way of intercepting these calls in a way which _is_ mockable and therefore testable. After this change we should be able to test expectations with `createNotice()` without having to expose too much of the internals of that function, other than that it relies on `uniqueId()` ```js jest.mock( 'lib/impure-lodash', () => ( { uniqueId: () => 'test-13' } ) expect( dispatch ).to.have.been.calledWith( createError( 'Test' ) ) ``` * Reader: Update Following and Manage empty state (Automattic#18835) * Reader: Update Following and Manage empty streams * Compress svg * Get rid of is-modifier * Analytics: fixed scripts loading callback never being called (Automattic#18885) The problem was the missing https: in OUTBRAIN_SCRIPT_URL * Me: Drop valueLink (Automattic#18870) A number of files in `/me` use the `form-base` mixin, which has provided a `valueLink` method (i.e. `linkState` drop-in replacement). This PR removes that method in favor of a `getSetting()`, `updateSetting()`, and `toggleSetting()` method, and changes `form-base` consumers to use those methods. In addition, this commit removes some other simple `valueLink` cases that aren't suitable for codemodding. * Store Orders: Switch to using the item ID as an identifier for line_items (Automattic#18882) * Store: Create country and state components that use WC API locations (Automattic#18821) * Create country/state dropdowns which use the location data from WC API * Use the new API-driven location selects in the `AddressView` edit state * Reset the state value when the country changes, and add a default value for unchosen locations * Fix component name * Add a readme * Add translation comments * Change the “State” label to Province if the country is Canada * Store: fix nav-utils export * PostTypeList: Remove `react-virtualized` and special variable-height logic (Automattic#18162) * Remove `ReactVirtualized` and variable-height code from `PostTypeList` This has caused us alot of problems in the past. Ideally, variable-height post items should just be handled by the browser's native reflow logic with no additional work needed. Add logic to load next page on scroll Add logic to avoid fetching multiple pages at once Minimize the time taken to re-fetch existing posts list content When loading a posts list with content from persistent storage, refresh the list immediately by requesting pages using a maximum of 5 concurrent requests. Estimate page count from *new* posts array and account for site changes This fixes an issue where changing the posts list query (by searching, author filter, picking a different site, etc.) would request a larger number of pages than desired. * Improve cross-browser compatibility of scroll detection Fixes scrolling behavior on Chrome 61+. See: https://bugs.chromium.org/p/chromium/issues/detail?id=157855 Implementation based on `react-virtualized` scroll detection: https://github.com/bvaughn/react-virtualized/blob/9.10.1/source/WindowScroller/utils/dimensions.js#L37 * Fix missing posts in the middle of a result set * Always render placeholder item if there are more posts to be loaded This ensures a smoother scrolling experience: the height of the posts list only changes when we actually load more pages, not just when another page starts loading. * Fix `isRequestingSitePostsForQueryIgnoringPage` for all-sites queries Two issues: - The `PostListWrapper` was sending extra parameters for taxonomy terms: `category: undefined, tag: undefined` - Site ID is missing for serialized all-sites queries, but the query comparison logic did not take this into account (fixed and added unit tests) * Increase page size to 40 * Load next page of posts sooner Increase the scroll threshold (in pixels) for loading the next page, and move this value to a constant. * Post type list: Multiple Selection Mode (Automattic#18761) * Add feature flag to control bulk edit mode for post type list. * Add "Select" button to toggle multi-select mode * Add post type list selection to state tree * Store multi-select mode state in state tree * Hook checkbox state to multiselect mode * Add tests for reducer and selectors * Hide drafts via visibility on select mode * Toggle off selection mode on nav * Remove unused SCSS variables * Add bulk edit bar * Disable control buttons when no items are selected * Position multi-select toggle correctly on small viewports * Enlarge hit area of post select checkboxes * Codemod to remove 'react-addons-linked-state-mixin' usages (Automattic#13925) * Site Settings: Add Disconnect Confirmation Page (Automattic#18796) Add a route ` /settings/disconnect-site/confirm/:site` that displays the `DisconnectJetpack` block. Additionally, fix fullscreen styling (by removing the SCSS workaround, and dispatching `setSection` with `has-no-sidebar` set to true instead -- props @sirreal). This then necessitates a fix to JITM to guard agains `null` actions. * Make data layer options optional (Automattic#18897) The options are optional, so this aligns the function signature to match. * Add postcss custom properties plugin (Automattic#18905) * Store: Prevent duplicate variant type names from being entered. (Automattic#18662) * Store: Prevent duplicate variant type names from being entered. * Add error message * Trim all the things. * Add getCurrentPlanPurchaseId selector (Automattic#16949) Add `getCurrentPlanPurchaseId` selector which will provide the purchase id from the site's current plan. This will make it possible to obtain purchase information about a site's current plan. The motivation for this change is that plans contain some information about expiration and renewal, but it does not appear to be very reliable. [Different logic](https://github.com/Automattic/wp-calypso/blob/7b57ac64f77bcd764a21a649b619659800e7767e/client/me/purchases/manage-purchase/purchase-meta.jsx#L149-L183) is applied on the purchases page and much of it is based on a specific purchase object obtained by ID. * Simple Payments: Minor label change and give some examples through form explanation * Refactor JetpackPlanDetails (Automattic#18589) * Refactor JetpackPlanDetails Just happened to notice this component in an unrelated conversation and saw it was missing out on some key Claypso principles so I refactored it to try and simplify the component and bring it in line with our code guidelines. Major changes: - Stop calling analytics directly and instead dispatch Redux actions - Split apart the enhanced from the basic component - Wrap components in `connect()` and `localize()` for side effects and translation - Extract the function to get tracks data for early-abort instead of chained if/else structures - Prefer declarative style over mutating a `props` object when building the JSX. - Remove a bug where the tracks events could end up firing off a number of times on re-render when it should only fire once. * Rewind: Add `is-discarded` CSS class to events in local testing (Automattic#18933) In preparation for work associating specific events in the activity log with a status of whether or not they appear to be active or discarded (when looking from the perspective of the latest restore operation) I'm adding in a flag set randomly when in local development environments in order to enable UI design work to start. Soon we should be replacing this with an actual discard-status field in the event data itself. * Codemods: Add assign-component-to-displayname-variable codemod * Refactor assign-component-to-displayname-variable (Automattic#18894) * refactor * args --> hocArgs * return no file * Run the remove-linked-state-mixin codemod (Automattic#14099) * Run the remove-linked-state-mixin codemod * Remove react-addons-linked-state-mixin from package.json * Add postcss custom properties to main style build step (Automattic#18909) * Add color schemes scss file (Automattic#18911) * Store: Omit pending orders from dashboard New Orders widget. (Automattic#18653) * Store: Omit pending orders from dashboard New Orders widget. * Add new order selector without pending paypal orders. * Add revenue selector too. * Update color scheme classes on Layout (Automattic#18912) * DevDocs: Make component header links obvious The DevDocs have a very useful feature where we can view a single component in isolation, rather than the full list. When developing an example, that feature massively improves the experience over constantly refreshing the full list and filtering. Without some kind of indicator, though -- like a link icon or an underline -- it's easy to miss the fact that the title of each component is a link to the singular view of that component, leading to unnecessary frustration and wasted time. * Color Schemes: Add CSS custom properties to Masterbar (Automattic#18913) * Add CSS custom properties to Masterbar * Add custom properties to layout loader * Enable feature on wpcalypso (Automattic#18938) * Use current user's ip country code for chart (Automattic#18940) * Framework: Upgrade dependencies to React 15.6 * Framework: Deprecate react-addons-test-utils * Framework: Fix broken test with hack * Reader: Prevent Settings link from overlapping with Site Title (Automattic#18939) * Shrinkwrap * Reader: Fix Edit link fullpost (Automattic#18943) * Consolidate state shape for happychat.ui (Automattic#18744) * fixup lostFocusAt reducer custom persistence mechanism * State: extract happychat.ui reducer from happychat * State: extract selectors related to happychat.ui.lostFocusAt * State: extract actions related to happychat.ui.lostFocusAt * State: ui.happychat.open reducer to happychat.ui.isOpen * State: ui.happychat.isMinimizing reducer to happychat.ui.isMinimizing * State: extract ui.happychat selectors to happychat/selectors * State: move ui/happychat actions to happychat/ui * Comments: Remove "Approve and reply" placeholder from the reply textarea (Automattic#18877) Remove the "Approve and reply to..." placeholder from the `CommentDetail` reply textarea on non-approved comments, and replace it with "Reply to...". * Comments: When post is missing a title use excerpt (Automattic#18884) Currently missing post titles are simply replaced by "Untitled", as we don't necessarily have any other information about the post loaded in state. This PR adds a `QueryPosts` component that only requests the post if: - The post title included in the comment object is missing. - And the post is not yet loaded in state. Then, uses the post excerpt instead of the title. * Editor: Revisions: Keep restore button fixed (Automattic#18822) * initial implementation * fix firefox height problem * prevent list double border * MailChimp dashboard UI view. (Automattic#18818) * Comments: Fix condition to render QueryPosts (Automattic#18950) The original idea was to request a post when the comment's post title wasn't available, to use the post excerpt instead. After testing, I've decided to simplify a bit the logic, missed a ! and didn't test well enough to notice it (it's necessary to clean the cache and check the network requests to notice that something is wrong). * Components: Remove `valueLink` prop from `SelectDropdown` (Automattic#18951) I mean, what's a valueLink supposed to do on a `<div />` anyway? :-D * Mailchimp Campaign Defaults UI component. (Automattic#18801) * Change createRenderer to new ShallowRenderer This follows documentation, which does not mention createRenderer. * WCS Labels - fixed event log/refund UI issues (Automattic#18920) * Added missing translate calls * Added busy indicator to the labels reprint button * Using currency formatting to display refundable amount * Removed redundant label used date checks * Notes - using event date to control opened days * Renamed order notes to activity log * Added the busy indicator to the refund button * Removed the extra spaces added by a script * Removed an empty constructor, updated a comment and variable names * MailChimp Setup and entry point. (Automattic#18837) * Reader a8c convos: modify copy of intro box (Automattic#18883) * Reader a8c convos: modify copy of intro box * missing period * period is part of link also secret version of link * Remove space from link * Activity log: Rewind button behavior (Automattic#18722) * Activity Log - Rewind dialog: homogenize markup for secondary actions to Button and update styling. Refactor redundant method and consolidate markup in a single place. * Activity Log - Rewind dialog: update behavior of Rewind button in day header. Disable after clicking and adding Rewind dialog inside day. Reactivate if Rewind dialog is canceled or if another Rewind button is clicked, either in ellipsis menu or day header. * Reduce function into shorter version * Components: add new property to FoldableCard that allows to disable the button that expands/collapses the card content. When it's disabled, its color changes to a light gray. Includes docs and example. * Activity Log - Rewind button: when the Rewind is initiated in the day header and the card expanded, the chevron arrow in the FoldableCard is disabled so users can't collapse it * Activity Log: make Rewind button in day header always blue when active unless there's a Rewind dialog inserted in this day * Activity Log: remove redundant checking since if the next prop is empty it will be enough to be different from current prop. Props @dmsnell for spotting this. * Activity Log: restore FoldableCard to the way it was before. Users can always expand/collapse day. On collapse, Rewind dialog will be dismissed, no matter if it was started through day header button or item within day. * Activity Log: put each var as a new const statement to comply with code guidelines * Activity Log - Rewind button: make code more readable by adding a separate loop to find out if the current day has a confirm dialog inserted * Activity Log - Rewind dialog: move tracking functions outside of component logic * Editor: fix tours relying on separate quick insert / insert dropdown buttons * Framework: Update Gridicons to v.2.0.5 (Automattic#18892) * Reader: Unflip Reply icon (Automattic#18891) * Framework: Reset title (document head) state after navigating (Automattic#8224) This pull request seeks to resolve an issue where document head state is not properly reset when navigating between screens. For example, if while viewing the Reader an unread count is assigned into the title, if I then navigate away from the Reader, that count will become stuck in the title. * Desktop: Add build-client-if-desktop * apply codemod: assign-component-to-displayname-variable to client/ folder (Automattic#18878) * apply codemod: assign-component-to-displayname-variable to client/ folder * npm run reformat-files * Add code to remove themes selection step. (Automattic#18908) The step has been removed for the 'themes', 'developer', and 'pressable' signup flows. * Guidelines: Recommend newlines at end of files (Automattic#18927) Docs: Guidelines: Recommend newlines at end of files * Fix import of lib/oauth-token which doesn't have a default export * Checkout: fix broken thank you page for site-less purchases (Automattic#18949) * Fix incorrect Jetpack Connect logic (Automattic#18873) * Reject Happychat auth promise (Automattic#18691) * Put react-hot-loader behind a feature flag * Jetpack connect: No explicit bind, handle props correctly (Automattic#18953) * Replace explicit bind with arrow functions * Correctly define Component constructor with props * Automated Transfers: stop polling for transfer status if the status is 'error' If the returned status is 'error', stop polling. This is the final state and it's not going to change. Until now, we only stopped polling on 'complete'. * TinyMCE: Add displayName on embed example to fix issue with DevDocs Without the displayName property, the embed dialog on the DevDocs example reads incorrectly. This adds the EmbedDialog display name to fix the issue. Fixes: Automattic#18650 * Domains: make getTld parsing a little smarter TLDs can be second or even third level which means “everything after the last dot” is an unsafe assumption when trying to parse a TLD out of a string. The only safe way really is to parse against a whitelist. The problem, unfortunately, is that list is 150 KB uncompressed which is way overkill for what we do in Calypso. So! This approach uses a stripped down whitelist (86 bytes compressed) and falls back to the naive “after last dot” parsing if it fails. I think this will get us where we need to be for a long time on the client side. * Login: Simplify code that generates canonical url * Login: Fix language switching no longer working This fixes the link in the locale suggestion notice that appears on the login page that would be otherwise ineffective. * Login: Add missing prop validation to Locale Suggestions component * Login: Fix small typo in Locale Suggestions component * Login: Fix warning thrown when clicking locale suggestion This gets rid of a 'forceUpdate(...): Can only update a mounted or mounting component. This usually means you called forceUpdate() on an unmounted component. This is a no-op. Please check the code for the Localized(Notice) component.' warning. * Framework: Pre-emptive fixes for the create-class codemod (Automattic#18986) * Framework: s/var (.*) = React\.createClass/const = React.createClass/g * PostExcerpt: defaultProps -> getDefaultProps * lib/mixins/data-observe: Add deprecation note to README * PostItem: Update visited color (Automattic#18967) * Add is_rewindable to Activity Log schema and items * add activityIsRewindable to persistence schema * Site Settings: Add JP Disconnect Flow Steps (Automattic#18749) * Site Settings: Enable Disconnect Flow in wpcalypso (Automattic#19011) * Extensions: Split extensions CSS into separate files when building calypso (Automattic#18823) Split extensions CSS into separate sections, only if the extensions’ package.json calls for a css module * Store Orders: Update status labels for "cash on delivery" orders (Automattic#18983) * Refactor & add tests for `OrderStatus` * Pass whole order object through to OrderStatus, so that we can check payment_method for status display * Switch places component is used to pass through the order object * Update payment string * Fix status variable (now inside order) so the classes are applied correctly. Also add tests for status-based classes * Update payment card for cash-on-delivery orders * Remove unused `method` from translate call * Refactor getAutomatedTransferStatus to fetchAutomatedTransferStatus (Automattic#19008) It was creating confusion since we already have a selector called `getAutomatedTransferStatus` which returns the current AT status for a site. On the other hand, `fetchAutomatedTransferStatus` sends a request to fetch the status. * MySites Sharing: give services a shimmed hasOwnProperty (Automattic#18845) * jsdiff / diff lib dependency: update to version 3.4.0 (Automattic#18828) * jsdiff / diff lib dependency: update to version 3.4.0 * Fix the tests -- we get counts now! * update the shrinkwrap * Publicize Actions: fix typo in the schema (Automattic#18843) * Site Setting Exporter: fix action-name in reducer (Automattic#18842) * publicize: remove unused middleware code (Automattic#18839) * publicize: add two missed action types * Revert "publicize: add two missed action types" This reverts commit de0321b. * remove unused middlewares * improve atomic store signup flow wordings (Automattic#18992) * Signup: fix suggestedUsernameSchema (Automattic#18841) * Disconnect Flow: Minor Copy Fix (Automattic#19014) * Store Orders: Add fees to single order views (Automattic#18729) * Add a `getOrderFeeTax` function to calculate taxes on fees * Add `getOrderFeeTotalTax` to grab total tax across all fees on an order * Add fee taxes to the total order tax value * Add `getOrderFeeTotal` function to calculate the sum of all fees on an order * Add fee lines to the order display * Add fee lines to the refund modal * Add fees into refund calculation * input widths / alignment * more refund modal styling fixes * refund modal width * Address review feedback * Use `getCurrencyFormatDecimal` to display price in `PriceInput`, and prevent partial-cent refunds. * Tests should be using `test()` now, not `it()` * Remove numberFormat proptype * Change out the formatting logic – don’t format the inputs while the user types, wait for them to leave the input. * Add “Fee” label under fees * Store Orders: Add functions to calculate total prices based on order data (Automattic#18964) * Add `getOrder{*}Total` functions for fetching totals from line items, shipping, etc given an order * Add single item cost helper * Add tests for getOrderTotal * Update imports for `getOrderRefundTotal` to new file * Move the fee total function to the totals file * Add fees into order total * Fix comment * MailChimp integration redux: action types, actions, reducers, selectors. (Automattic#18748) * Domains: refactored HiddenInput Component to ES6 (Automattic#18989) * refactored component => ES6 and added tests; removed superfluous conditions checking whether the input should be toggled * removed invalid css class name hidden-input and updated tests and CSS decs * Notifications: Update notifications panel to version 1.2.6 (Automattic#19021) * Notifications: Update notifications panel to version 1.2.5 * Notifications: Update notifications panel to version 1.2.6 * Remove last two sections from rebrand cities thank you page (Automattic#19031) * Jetpack Connect: Add snapshot test for plans-skip button (Automattic#19009) A really simple snapshot test, more to play with snapshot testing than anything. * WCS Labels - fixed purchase flow issues (Automattic#18928) * Conditionally displaying the carrier name * Removed the FieldDescription component * Alphabetized action.js exports * Removed the invalid_nonce error handling * Removed a redundant comment and eslint-disable * Fixed coding standards * Moved the step spinner to the right of the summary * Removed the duplicated foldable card styles * Using the busy indicator on the purchase button instead of spinner * Removed the unused pulsate CSS animation * Extract shouldFormat util and use with prettier (Automattic#18991) * Validation: fix validation warning since the type is initially null (Automattic#19017) * Pages: Update schedule indicator to use relative time status component We have a relative time status component that is used on scheduled post lists to show when the post will be published (from the current time). This commit updates the pages list to use the same component. When viewing /pages/scheduled/, users should now see the indicator letting them know when the page will be scheduled. When clicked the link will either take them to the page editor or page preview when appropriate. Fixes: Automattic#18418 * Pages: Update scheduled time stamp to fix linting errors The previous commit was setting off some linting errors because the classnames were not arranged correctly. This updates the format and return method so the classnames follow the guidelines and linting errors should be fixed. * Pages: Update styling of scheduled page gridicon This updates the styling of the gridicon to match the 12px size of the other tabs within /pages by allowing the relative time status component to accept a prop of gridicon size. * Fix printing labels in iOS & Android (Automattic#19012) * Make label printing work in iOS (same logic changes as in WooCommerce Services, kudos to @joshuaja) * Fix label printing in Android (it purges revoked URLs instantly) * Fixed modal styles in IE11 (Automattic#19026) * TokenField: Refactor to drop isMounted and strings refs (Automattic#19003) Using component state and lifecycle methods instead. * Clean Happychat CSS (Automattic#19035) * Delete unused .happychat__loading class * Fix .happychat__page class name * Delete unused .happychat__timeline-join-message class * Delete unused .happychat__message-meta class * Delete unused .happychat__message-avatar class * Delete unused .support-browser class * Disconnect Flow: Use TokenField in 'Missing Feature' Step (Automattic#19013) * Disconnect Flow: Use TokenField in 'Missing Feature' Step * Link to Jetpack Admin Page after plan is set up in Jetpack Thank You Page (Automattic#19039) * Editor: Revisions: Auto-open the sidebar when clicking "History" (Automattic#19041) * Store: Reload shipping label PDF when updating paper size in reprint dialog (Automattic#18930) * Reload fileData in response to paper size update in label reprint dialog * Avoid storing reprint PDF if paperSize changed since request was made * Data Layer: Update comments to use the new v1.1 comments tree endpoint. (Automattic#18800) * Revert "Data Layer: Update comments to use the new v1.1 comments tree endpoint. (Automattic#18800)" (Automattic#19050) This reverts commit f0b4919. * Remove read/following/mine* endpoints from undocumented.js (Automattic#19043) * Atomic Store: show Atomic checkout-thank-you for Atomic sites as well (Automattic#19023) * Add MailChimp to wp.com store. ( API, UI, Redux ) (Automattic#17434) MailChimp WooCommerce integration. * Remove Start setup wizard. (Automattic#19057) * Store Promotions: Move list state up a level This moves the list page states up a level to make room for edit states. * Store Promotions: Add selectors for edit states This adds selectors to get promotion edits, edits overlaid on top of the existing promotions, and the currently editing promotion. * Store Promotions: edit state selector adjustments This adjusts mostly the test code for the edit state selectors. * Store Promotions: Rename test suite Fix an incorrect test suite name * Store Promotions: Add create coupon form This adds the base form code to create a coupon and modify the edit state for it. * Store Promotions: Add selectors for edit states This adds selectors to get promotion edits, edits overlaid on top of the existing promotions, and the currently editing promotion. * Store Promos: Discount type and amount component This moves the discount type and amount fieldsets to a separate component so they can be reused for product sales. * Store Promotions: Cleaned up selector tests. Through the merge/rebases, there ended up duplicate tests. This removes them. * Store Promotions: Addressed PR comments This addresses some minor comments for the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on disabling common js transpilation to improve the calypso build process, I ran into 7 issues where there were items being imported/exported that are missing.
One of them was:
It looked like the reducer/test were just using the wrong action-type. Is this the right fix?
Thanks for the help!
Note: this is a blocker for #16057
cc @jordwest @gwwar