Framework: Localize and fix client/layout/error #18610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to now, server/bundler/loader was calling static methods of the component. This causes problems once the component is `localize()`d, since those methods aren't hoisted. However, we can easily turn those static methods into module level functions.
ockham
added
Framework
[Status] Needs Review
psealock
approved these changes
Oct 8, 2017
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now, server/bundler/loader was calling static methods of the component. This causes problems once the component is
localize()d, since those methods aren't hoisted.However, we can easily turn those static methods into module level functions.
Background: #18590 (comment)
To test:
LoadingErrorcomponent-related) error described at Framework: Run i18n-mixin-to-localize codemod #18590 (comment)