Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Orders: Edit customer info on an order #18579

Merged
merged 9 commits into from
Oct 11, 2017
Merged

Store Orders: Edit customer info on an order #18579

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
32f2941
Connect the customer info component, and add “edit” links on the addr…
ryelle Oct 3, 2017
824a4b9
Add dialogs to handle editing & saving the customer info
ryelle Oct 4, 2017
abf5067
Enable copy-to-shipping for billing changes
ryelle Oct 4, 2017
89f22ac
Switch button style to primary
ryelle Oct 5, 2017
86d37aa
Fix label for shipping dialog
ryelle Oct 5, 2017
83f439f
Update proptypes & defaults
ryelle Oct 9, 2017
b58fec2
Remove site from the connected props, only grab siteId
ryelle Oct 9, 2017
d8f70c1
Address edit button styling
jameskoster Oct 10, 2017
7641bff
Address modal fieldset margins
jameskoster Oct 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update proptypes & defaults
  • Loading branch information
@ryelle
ryelle committed Oct 9, 2017
commit 83f439f00c882bb3d9c2157c2f705c35b910efb1
2 changes: 2 additions & 0 deletions client/extensions/woocommerce/app/order/order-customer/dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ class CustomerAddressDialog extends Component {
closeDialog: PropTypes.func,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want updateAddress() here along with a default below?

isBilling: PropTypes.bool,
isVisible: PropTypes.bool,
updateAddress: PropTypes.func.isRequired,
};

static defaultProps = {
Expand All @@ -60,6 +61,7 @@ class CustomerAddressDialog extends Component {
closeDialog: noop,
isBilling: false,
isVisible: false,
updateAddress: noop,
};

constructor( props ) {
Expand Down
3 changes: 3 additions & 0 deletions client/extensions/woocommerce/app/order/order-customer/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,14 @@ import SectionHeader from 'components/section-header';

class OrderCustomerInfo extends Component {
static propTypes = {
editOrder: PropTypes.func.isRequired,
isEditing: PropTypes.bool,
orderId: PropTypes.number.isRequired,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, I know, me and my proptype comments 😆 isEditing, site, and siteId are now being passed in the connect - though looks like site isn't being used, only the id.

order: PropTypes.shape( {
billing: PropTypes.object.isRequired,
shipping: PropTypes.object.isRequired,
} ),
siteId: PropTypes.number.isRequired,
};

state = {
Expand Down