Store: Add the ability to reply to product reviews. #18377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinshreve
added
Store
[Status] Needs Review
|
As mentioned in slack - a little problem with sending, especially multi-line replies
|
allendav
reviewed
Sep 29, 2017
| const hasCommentText = commentText.trim().length > 0; | ||
|
|
||
| // Only show the scrollbar if the textarea content exceeds the max height | ||
| const hasScrollbar = textareaHeight === TEXTAREA_MAX_HEIGHT; |
There was a problem hiding this comment.
Do you want exactly equal here, or maybe >= ?
allendav
reviewed
Sep 29, 2017
| export function announceCreateFailure( { dispatch } ) { | ||
| dispatch( | ||
| errorNotice( | ||
| translate( "Your reply couldn't be posted." ), |
There was a problem hiding this comment.
Usually we do single quoted strings with escaped interior single quotes, no?
allendav
approved these changes
Sep 29, 2017
…omparison on text area height, and make the submit box padding a bit wider to make it easier to hit.
justinshreve
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to reply to product reviews. The UI and behavior here matches normal comments management (see #17047 as well). It also adjusts the reply view to be sorted oldest -> newest like a thread.
Closes #17047. Closes #17046.
To Test:
npm run test-client client/extensions/woocommerce/stateand make sure all tests pass.http://calypso.localhost:3000/store/reviews/:siteand find a review.