-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atomic: update eligibility warning messages #17469
Conversation
title: translate( 'Primary domain not pointing to WordPress.com servers' ), | ||
description: translate( 'Point your primary domain to WordPress.com servers to resolve.' ), | ||
supportUrl: 'https://support.wordpress.com/domain-helper/', | ||
title: translate( 'Domain not pointing to WordPress.com servers' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗 This change is safe, we'll keep the existing 17 translations.
supportUrl: 'https://support.wordpress.com/domain-helper/', | ||
title: translate( 'Domain not using WordPress.com name servers' ), | ||
description: translate( 'Your domain must use WordPress.com name servers to support custom code. ' + | ||
'Follow step 2 in "add domain mapping" to resolve this.' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be more clear.
"Add domain mapping" (probably better to keep the same case as the support page) doesn't have any "internal" steps, but is itself the first step of the page.
You could be talking about:
-
Click the Upgrade button next to “Already own a domain?”
which is the second line of the "Add domain mapping" section. -
2. Ask your domain provider to update your DNS settings
which is the second step of the entire page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update this to link to the section as well
I just helped a user yesterday who ran into this so it's top of mind for me. Small suggestion on the security certificate language to have it be similarly structured to the other messages in this panel and to shorten the message.
And since there's nothing the user can do to resolve that error, might also be worth changing "You must resolve the errors above before proceeding" to
I also think the other error messages could be tweaked as well and have some ideas, but I was confused by the difference between "Domain not pointing to WordPress.com servers:" and "Domain not using WordPress.com name servers". Especially since this was for a domain that I just registered on WordPress.com. |
I've gone through the NUX process and set up three separate business sites in working this PR, but was never able to duplicate the error messaging that needs to be reviewed. (I did go down the same scary path that I'll report with some screenshots where it's appropriate.) Using the handy screenshot shared above, here are some thoughts on language. I will need to know which words are linked to where above to check out the docs. I like both of @megsfulton's suggestions for streamlining she notes above. Very small tweaks, here:
|
I am seeing the same issues uploading plugins on a new Atomic site as @kristastevens - documented in |
@@ -108,7 +108,7 @@ export const EligibilityWarnings = ( { | |||
<Card className="eligibility-warnings__confirm-box"> | |||
<div className="eligibility-warnings__confirm-text"> | |||
{ ! isEligible && translate( | |||
'You must resolve the errors above before proceeding. ' | |||
'The errors above must be resolved before proceeding. ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😞 17 existing translations will be lost with this change.
a047412
to
2f2d008
Compare
2f2d008
to
d9d0fc2
Compare
description: translate( | ||
'Please try again in a few minutes: you will be able to proceed once we finish setting up your security settings.' | ||
'We are setting up a security certificate for you domain now. Please try again in a few minutes.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for you domain
should be "for your domain"
If we fix the typo this looks good to me. Officially handing this off to @gwwar :-) |
Thanks for the review @rralian ! |
This PR is to resolve confusing and unhelpful messaging regarding some of the blockers for using Automated Transfer. I'm also changing the "resolve" link to point to instructions to help resolve these issues. The warnings were previously pointing to the domain helper which in practice hasn't been helpful for resolving these issues.
Testing
Unless you see any obvious syntax issues, you can probably just look at the copy and the linked support pages to confirm it all makes sense. But if you'd like to run a quick test, go through NUX, create a business site with free credits, and immediately try to install a plugin. You'll likely get caught by the missing SSL error.