Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic: update eligibility warning messages #17469

Merged
merged 5 commits into from
Sep 6, 2017

Conversation

rralian
Copy link
Contributor

@rralian rralian commented Aug 23, 2017

This PR is to resolve confusing and unhelpful messaging regarding some of the blockers for using Automated Transfer. I'm also changing the "resolve" link to point to instructions to help resolve these issues. The warnings were previously pointing to the domain helper which in practice hasn't been helpful for resolving these issues.

Testing

Unless you see any obvious syntax issues, you can probably just look at the copy and the linked support pages to confirm it all makes sense. But if you'd like to run a quick test, go through NUX, create a business site with free credits, and immediately try to install a plugin. You'll likely get caught by the missing SSL error.

@rralian rralian added [Status] Needs Copy Review Add this when you'd like to get a review / feedback from the Editorial team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Enhancement labels Aug 23, 2017
@rralian rralian self-assigned this Aug 23, 2017
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Size] S Small sized issue label Aug 23, 2017
title: translate( 'Primary domain not pointing to WordPress.com servers' ),
description: translate( 'Point your primary domain to WordPress.com servers to resolve.' ),
supportUrl: 'https://support.wordpress.com/domain-helper/',
title: translate( 'Domain not pointing to WordPress.com servers' ),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 This change is safe, we'll keep the existing 17 translations.

supportUrl: 'https://support.wordpress.com/domain-helper/',
title: translate( 'Domain not using WordPress.com name servers' ),
description: translate( 'Your domain must use WordPress.com name servers to support custom code. ' +
'Follow step 2 in "add domain mapping" to resolve this.' ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be more clear.

"Add domain mapping" (probably better to keep the same case as the support page) doesn't have any "internal" steps, but is itself the first step of the page.
You could be talking about:

  • Click the Upgrade button next to “Already own a domain?”
    which is the second line of the "Add domain mapping" section.

  • 2. Ask your domain provider to update your DNS settings
    which is the second step of the entire page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update this to link to the section as well

@megsfulton
Copy link

I just helped a user yesterday who ran into this so it's top of mind for me.

Small suggestion on the security certificate language to have it be similarly structured to the other messages in this panel and to shorten the message.

Security certificate required: We are setting up a security certificate for you domain now. Please try again in a few minutes.

And since there's nothing the user can do to resolve that error, might also be worth changing "You must resolve the errors above before proceeding" to

The errors above must be resolved before proceeding. Have questions? Please contact support.

I also think the other error messages could be tweaked as well and have some ideas, but I was confused by the difference between "Domain not pointing to WordPress.com servers:" and "Domain not using WordPress.com name servers". Especially since this was for a domain that I just registered on WordPress.com.

screen shot 2017-08-23 at 11 01 32 am

@kristastevens
Copy link

I've gone through the NUX process and set up three separate business sites in working this PR, but was never able to duplicate the error messaging that needs to be reviewed. (I did go down the same scary path that I'll report with some screenshots where it's appropriate.)

Using the handy screenshot shared above, here are some thoughts on language. I will need to know which words are linked to where above to check out the docs.

I like both of @megsfulton's suggestions for streamlining she notes above.

Very small tweaks, here:

We cannot manage your site because your domain does not point to WordPress.com servers. Follow the instructions to reset your domain's A record to resolve this.

@alisterscott
Copy link
Contributor

I am seeing the same issues uploading plugins on a new Atomic site as @kristastevens - documented in p4k3M4-2oZ-p2

@@ -108,7 +108,7 @@ export const EligibilityWarnings = ( {
<Card className="eligibility-warnings__confirm-box">
<div className="eligibility-warnings__confirm-text">
{ ! isEligible && translate(
'You must resolve the errors above before proceeding. '
'The errors above must be resolved before proceeding. '
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞 17 existing translations will be lost with this change.

@gwwar gwwar force-pushed the update/eligibility-warning-messaging branch from a047412 to 2f2d008 Compare September 6, 2017 17:38
@gwwar gwwar force-pushed the update/eligibility-warning-messaging branch from 2f2d008 to d9d0fc2 Compare September 6, 2017 18:49
@gwwar
Copy link
Contributor

gwwar commented Sep 6, 2017

Here's what this looks like with all holds. I made a minor tweak to the NO_WPCOM_NAMESERVERS copy and link in d9d0fc2

warnings

description: translate(
'Please try again in a few minutes: you will be able to proceed once we finish setting up your security settings.'
'We are setting up a security certificate for you domain now. Please try again in a few minutes.'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for you domain

should be "for your domain"

@rralian
Copy link
Contributor Author

rralian commented Sep 6, 2017

If we fix the typo this looks good to me. Officially handing this off to @gwwar :-)

@rralian rralian added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 6, 2017
@gwwar
Copy link
Contributor

gwwar commented Sep 6, 2017

Thanks for the review @rralian !

@gwwar gwwar merged commit 17a48e0 into master Sep 6, 2017
@gwwar gwwar deleted the update/eligibility-warning-messaging branch September 6, 2017 23:09
@sirreal sirreal removed the [Status] Needs Copy Review Add this when you'd like to get a review / feedback from the Editorial team on your PR label Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants