Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader: Add back button to Search #13510

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Reader: Add back button to Search #13510

merged 1 commit into from
Apr 28, 2017

Conversation

jancavan
Copy link
Contributor

This fixes: #13387

Before:
screenshot 2017-04-28 13 22 59

After:
screenshot 2017-04-28 13 23 02

@jancavan jancavan added [Feature] Reader The reader site on Calypso. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Bug labels Apr 28, 2017
@jancavan jancavan self-assigned this Apr 28, 2017
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/reader/search-back-to-sidebar-button

@matticbot matticbot added the [Size] S Small sized issue label Apr 28, 2017
blowery
blowery approved these changes Apr 28, 2017
View reviewed changes
Copy link
Contributor

@blowery blowery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blowery blowery added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 28, 2017
@jancavan jancavan merged commit 2278e4a into master Apr 28, 2017
@jancavan jancavan deleted the add/reader/search-back-to-sidebar-button branch April 28, 2017 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blowery blowery blowery approved these changes

Assignees

@jancavan jancavan

Labels
[Feature] Reader The reader site on Calypso. [Size] S Small sized issue [Type] Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reader: Missing Back button in Search in <480px
3 participants
@jancavan @matticbot @blowery