Themes: Fix og:url meta, add canonical link tag #13505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test live: Note: live doesn't work. |
ockham
added
Server Side Rendering
[Feature Group] Appearance & Themes
|
Tested on Chrome:
Also checked code. Seems even clearer to me now. 👍 🚢 |
folletto
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
Thanks for reviewing @folletto! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our
<meta property="og:url" />tags would set theircontentattr to eitherhttps://wordpress.com/themes/premium,https://wordpress.com/themes/free(depending on selected tier), or justhttps://wordpress.com/themesin all other cases.This PR changes this so that
metaalways reflects the currentpathname(i.e. route without query string). It also adds a<link rel="canonical" href="..." />.To test: Logged-out, land on each of the following, and check Page Source. Verify that the
metaand thelinkmentioned above are present and correctly point to the corresponding WordPress.com URL.