AT: remove jetpack disconnect button from AT sites #12305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rralian
added
Jetpack
[Status] Needs Review
|
Works for me. |
|
Works for me and nice fix! |
lamosty
added
[Status] Ready to Merge
and removed
[Status] Needs Review
jhnstn
pushed a commit
that referenced
this pull request
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed one spot where users can disconnect AT sites. Disconnecting Jetpack on an AT site will cause problems for the site.
Testing instructions
AT Site
Login to an AT site in Calypso, go to
http://calypso.localhost:3000/settings/general/:site, scroll to the bottom and make sure in the Jetpack section that you do not see a big red "disconnect site" button. It should look like this.Jetpack Site
Now login to a non-AT Jetpack site, go to
http://calypso.localhost:3000/settings/general/:site, scroll to the bottom and make sure in the Jetpack section that you do see a big red "disconnect site" button. It should look like this.