Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AT: Remove theme-upload nux variant with the new AT capability #12287

Merged
merged 1 commit into from
Mar 17, 2017
Merged

AT: Remove theme-upload nux variant with the new AT capability #12287

merged 1 commit into from
Mar 17, 2017

Conversation

rralian
Copy link
Contributor

@rralian rralian commented Mar 17, 2017

This test was set to 10%, I'm just turning it off for now so it doesn't get confused with the AT flow.

@rralian rralian added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 17, 2017
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=remove/nux-theme-upload-flow

vindl
vindl approved these changes Mar 17, 2017
View reviewed changes
Copy link
Member

@vindl vindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:
I'll create a follow-up janitorial PR to clean up the rest of the code that was introduced for this test.

@vindl vindl added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 17, 2017
@gwwar gwwar merged commit 943b167 into master Mar 17, 2017
@gwwar gwwar deleted the remove/nux-theme-upload-flow branch March 17, 2017 21:33
@vindl vindl mentioned this pull request Mar 20, 2017
Merged
vindl added a commit that referenced this pull request Mar 21, 2017
@vindl
Remove upload theme option that was introduced as part of an AB test. (…
ad9ad88 
…#12323)

Removes theme upload AB test that was introduced in #7683.
The actual test was removed in #12287, and the purpose of this PR is to clean up the unused code.
@matticbot matticbot added the [Size] S Small sized issue label Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vindl vindl vindl approved these changes

Assignees
No one assigned
Labels
[Size] S Small sized issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rralian @matticbot @vindl @gwwar