Revert "Media: Update/scarier media delete message" #11919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3adf639.
rralian
added
the
[Status] Needs Review
gwwar
approved these changes
Mar 8, 2017
|
Yes, I failed testing this branch as well. |
matticbot
removed
the
[Status] Needs Review
alisterscott
deleted the
revert-11629-update/scarier-media-delete-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11629
Poor testing on my part. I thought I was just changing the design and wording for a simple button. But I didn't realize that using a component changes the functionality of the buttons, and so I hadn't actually tested to notice that "delete" stops working.