Skip to content

Help Center: add bg color for elements has-background classname #103847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

Help Center: add bg color for elements has-background classname #103847

merged 1 commit into from
Jun 2, 2025
+9 −0

Conversation

alshakero
Copy link
Member

@alshakero alshakero commented May 30, 2025 •
edited
Loading

Fixes DOTSUP-48

Testing

  1. Open the Help Center.
  2. Search for Style your site.
  3. Verify the change below

Screenshot

Before After
image image

@alshakero alshakero requested a review from a team as a code owner May 30, 2025 17:08
@alshakero alshakero added the [Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens. label May 30, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 30, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-146388
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-146388&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-146388&env=a8c-for-agencies

@alshakero alshakero requested a review from fditrapani May 30, 2025 17:09
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug dotsup-48-fix-help-center-content-background on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

fditrapani
fditrapani approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@fditrapani fditrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for this update. Looks great.

rcrdortiz
rcrdortiz approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@rcrdortiz rcrdortiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, 🚢

@alshakero alshakero merged commit d6eeabb into trunk Jun 2, 2025
13 of 15 checks passed
@alshakero alshakero deleted the dotsup-48-fix-help-center-content-background branch June 2, 2025 09:54
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcrdortiz rcrdortiz rcrdortiz approved these changes

@fditrapani fditrapani fditrapani approved these changes

Assignees
No one assigned
Labels
[Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alshakero @matticbot @rcrdortiz @fditrapani