Skip to content

Remove CrowdsignalOauthMasterbar and usage in logged-out #103845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chriskmnds
Copy link
Contributor

@chriskmnds chriskmnds commented May 30, 2025

Fixes https://linear.app/a8c/issue/DOTCOM-13395/crowdsignal

Proposed Changes

This follows up from #103830 to completely remove the custom CrowdsignalOauthMasterbar.

We are doing this separately to unblock the Login migration and test/confirm that no other usages exist outside of the Login screen. It is part of the logged-out layout for Crowdsignal, presumably more general than Login.

Why are these changes being made?

Part of https://linear.app/a8c/issue/DOTCOM-13395/crowdsignal

Testing Instructions

  • Build passing. No other references exist for this component.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@chriskmnds chriskmnds self-assigned this May 30, 2025
@chriskmnds chriskmnds requested a review from a team May 30, 2025 16:19
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 30, 2025
Copy link

github-actions bot commented May 30, 2025

@matticbot
Copy link
Contributor

matticbot commented May 30, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~435 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-reauth-required      -1581 B  (-0.1%)     -435 B  (-0.1%)
entry-main                 -1581 B  (-0.1%)     -435 B  (-0.1%)
entry-login                -1581 B  (-0.1%)     -435 B  (-0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@chriskmnds chriskmnds force-pushed the update/connect-refresh-login-crowdsignal-masterbar-removal branch from ef18463 to 8b9c2b1 Compare May 30, 2025 17:02
@matticbot
Copy link
Contributor

matticbot commented May 30, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/connect-refresh-login-crowdsignal-masterbar-removal on your sandbox.

@chriskmnds chriskmnds force-pushed the update/connect-refresh-login-crowdsignal branch from bd4d062 to fe1de01 Compare June 3, 2025 08:47
Base automatically changed from update/connect-refresh-login-crowdsignal to trunk June 3, 2025 09:09
@chriskmnds chriskmnds force-pushed the update/connect-refresh-login-crowdsignal-masterbar-removal branch from 8b9c2b1 to 4add746 Compare June 3, 2025 09:12
@chriskmnds chriskmnds merged commit 474a15d into trunk Jun 3, 2025
11 checks passed
@chriskmnds chriskmnds deleted the update/connect-refresh-login-crowdsignal-masterbar-removal branch June 3, 2025 09:46
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants