Skip to content

Experiment streamlining the plans grid + checkout:: Update title copy in Checkout upsell widget #103835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2025
Merged

Experiment streamlining the plans grid + checkout:: Update title copy in Checkout upsell widget #103835

merged 2 commits into from
Jun 3, 2025
+32 −26

Conversation

claudiucelfilip
Copy link
Contributor

Part of pdtkmj-3DM-p2#comment-7013

Proposed Changes

  • This updates the Checkout upsell widget title copy by adding an extra for the treatment variations of the streamlined pricing

Why are these changes being made?

  • We want the title to be more clear that the longe therm discounts are additional to the current discount

Testing Instructions

  • To test this feature, you'll need to be assigned to a checkout treatment variation of the calypso_streamlined_plans_checkout experiment
  • Go through the onboarding flow to get assigned
  • On checkout, you should see the update title on the upsell widget
Before After
Screenshot 2025-05-30 at 14 16 36 Screenshot 2025-05-30 at 14 15 55

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@claudiucelfilip claudiucelfilip requested a review from a team May 30, 2025 11:18
@claudiucelfilip claudiucelfilip self-assigned this May 30, 2025
@claudiucelfilip claudiucelfilip requested a review from a team as a code owner May 30, 2025 11:18
@claudiucelfilip claudiucelfilip added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels May 30, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-146328
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-146328&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-146328&env=a8c-for-agencies

@matticbot
Copy link
Contributor

matticbot commented May 30, 2025 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~29 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
checkout                      +284 B  (+0.0%)      +29 B  (+0.0%)
a8c-for-agencies-client       +284 B  (+0.0%)      +29 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@claudiucelfilip claudiucelfilip force-pushed the update/streamlined-pricing-experiment-extra-term-savings-copy branch from a5c4dfe to 28e6ab5 Compare May 30, 2025 11:23
dlind1
dlind1 approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@dlind1 dlind1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the strings from use-plan-billing-description.tsx.

packages/plans-grid-next/src/hooks/data-store/use-plan-billing-description.tsx Outdated
@@ -287,15 +287,21 @@ export default function usePlanBillingDescription( {
} else if ( showStreamlinedBillingDescription ) {
// When streamlined price experiment is active, use simplified billing description
if ( PLAN_ANNUAL_PERIOD === billingPeriod ) {
return translate( 'per month, billed annually' );
return translate( 'per month, billed every %(months)s months', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these changes should be in #103833?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for catching that!

@a8ci18n
Copy link

a8ci18n commented May 30, 2025 •
edited
Loading

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17526673

Thank you @claudiucelfilip for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented May 31, 2025

Translation for this Pull Request has now been finished.

@claudiucelfilip claudiucelfilip merged commit da1aef8 into trunk Jun 3, 2025
10 of 11 checks passed
@claudiucelfilip claudiucelfilip deleted the update/streamlined-pricing-experiment-extra-term-savings-copy branch June 3, 2025 05:16
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlind1 dlind1 dlind1 approved these changes

Assignees

@claudiucelfilip claudiucelfilip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@claudiucelfilip @matticbot @a8ci18n @dlind1