Skip to content

Themes with both section, font and combined style variations look like they have duplicate variations #97134

Open
@dsas

Description

Quick summary

The Twenty Twenty Five theme is showing 24 style variations in the theme showcase but there are only 8 actual variations included with the theme. The theme makes use of separate typeset (8) and colour sets (7), which all require separate style variation json files.

They're technically different variations but seem like duplicates because they have the same name. For example there is a twilight style variation which uses a colour set and a typeset as well as various block-specific settings. There is also a Twilight colour set which is solely a color set (the same palette as in the full Twilight style variation).

Image

This also happens for the assembler theme but it seems less duplicative because all of the variations have different names - there are color sets and typesets, but no combined ones with the same name.

Steps to reproduce

  1. Go to https://wordpress.com/theme/twentytwentyfive/

What you expected to happen

The style variations to look clearly different on the little 'microwave'.

What actually happened

Some of the style variations look the same and also have the same name, e.g. the two midnight options

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Both

Logs or notes

WordPress.org faced the same problem. They addressed it by only displaying style variations with the same name once - in which case they displayed the one with the longest settings.

Longer term we should look at how we display style variations, typesets and coloursets within the theme showcase.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions