The two or three first template Revisions are unavailable (works fine after that)

[happychait]

Quick summary

I don't see the template revisions in the Site Editor for the Archive and 404 templates.

Steps to reproduce

1. Start in the Site Editor
2. Edit the 404 template to customize it.
3. Check for revisions on the right sidebar of the template, to revert to the default 404 template.

What you expected to happen

Revisions should be available as they are part of Gutenberg 15.2

What actually happened

No link to access template revisions.

Here are my testing videos showing I customized Archive and 404 templates in the Heiwa theme, but once you open the Site Editor and go in to the template editor, the revisions are unavailable.

CleanShot.2023-03-21.at.15.31.08.mp4

CleanShot.2023-03-21.at.16.01.11.mp4

Impact

One

Available workarounds?

No and the platform is unusable

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

No response

[jordesign]

I've triaged this and confirmed it happens on WPCOM Simple and Atomic sites - but not on a fresh Self Hosted Wordpress installation with GB 15.3 active.

[dsas]

I was playing around with template revisions yesterday and the revisions screen itself is currently pretty broken.

There's a GB issue open to fix it and an equivalent core bug marked as blocking WP 6.3.

There is a PR open with a core fix. Maybe we want get that in dotcom before deploying the fix for this (though we can still look into the bug and prepare a PR).

---

Dunno where you are with this @BogdanUngureanu but I came across the original PR when looking for the above and it says:

• When merging into core, prepare_revision_links() should be merged with
• WP_REST_Templates_Controller::prepare_links().

Might be a good thing to check!

[BogdanUngureanu]

I was playing around with template revisions yesterday and the revisions screen itself is currently pretty broken.

There's a GB issue open to fix it and an equivalent core bug marked as blocking WP 6.3.

There is a PR open with a core fix. Maybe we want get that in dotcom before deploying the fix for this (though we can still look into the bug and prepare a PR).

Dunno where you are with this @BogdanUngureanu but I came across the original PR when looking for the above and it says:

• When merging into core, prepare_revision_links() should be merged with
• WP_REST_Templates_Controller::prepare_links().

Might be a good thing to check!

Thanks for the links! I think those issues are related to the revision page, not why the revision links are not showing in the sidebar.

I've made a few tests and it looks like on Atomic is working(ish); the revision link appears when the user makes two distinct changes on the page, which was an unexpected behavior (at least for me); meanwhile on Simple, I wasn't able to make the links appear at all.

I haven't done an in-depth technical review about why it's not working on Simple, but I think we should continue with that; maybe it's a core issue for multisites.

[dsas]

I think those issues are related to the revision page, not why the revision links are not showing in the sidebar.

Yep 100%, just trying to point out that the revision page is pretty broken for templates so I don't think we should ship a link to the revisions page until the revisions page is fixed.

Maybe it's a multi-site issue. Maybe it's an issue from how we sync code from core to wpcom (as the comment I quoted says there's some sync stuff from gb to core), maybe it's something completely different. IDK but I'm sure you'll soon find out!

[BogdanUngureanu]

Looks like the problem in WPCOM is because the wrong template controller is loaded. I've opened a diff that fixes the problem by adding an additional guard. D106565-code