Improve how Renovate groups NodeJS PRs (#80652)

- Setup the group manually
- Match node packages in CircleCI
- Regex match main docker image node version
- Use nvm for GitHub actions since it's easy
- Avoid referencing explicit Node version

.github/ISSUE_TEMPLATE/tooling_request.yml

@@ -19,6 +19,4 @@ body:
     attributes:
       label: Context
       description: Provide more context as applicable.
-      placeholder: |
-        eg. nodeJS: 18.13.0
-            browser: Firefox Nightly 92.0a1
+      placeholder: 'e.g. OS: ubuntu'

.github/workflows/editing-toolkit-plugin.yml

@@ -11,13 +11,11 @@ jobs:
     name: Run PHPunit tests.
     runs-on: ubuntu-latest
     steps:
-      - name: Set up Node
-        uses: actions/setup-node@v1
-        with:
-          node-version: '^18.13.0'
-
       - name: Checkout code
         uses: actions/checkout@HEAD
+      - uses: actions/setup-node@v3
+        with:
+          node-version-file: '.nvmrc'
 
       - name: Composer install
         uses: nick-zh/composer-php@HEAD

.github/workflows/gardening.yml

@@ -27,7 +27,7 @@ jobs:
      - name: Setup Node
        uses: actions/setup-node@v3
        with:
-         node-version: ^18.13.0
+         node-version-file: '.nvmrc'
 
      - name: Wait for prior instances of the workflow to finish
        uses: softprops/turnstyle@v1

.github/workflows/icfy-stats.yml

@@ -9,12 +9,11 @@ jobs:
     env:
       NODE_OPTIONS: --max-old-space-size=4096
     steps:
-      - name: Set up Node
-        uses: actions/setup-node@v1
-        with:
-          node-version: '^18.13.0'
       - name: Checkout code
         uses: actions/checkout@v2
+      - uses: actions/setup-node@v3
+        with:
+          node-version-file: '.nvmrc'
       - name: Fetch git history
         run: git fetch --prune --unshallow
       - name: Install dependencies

packages/calypso-package-generator/package.json

@@ -16,10 +16,6 @@
 	"bugs": "https://github.com/Automattic/wp-calypso/issues",
 	"homepage": "https://github.com/Automattic/wp-calypso/tree/HEAD/packages/generators#readme",
 	"type": "module",
-	"engines": {
-		"node": "^16.17.0",
-		"yarn": "^3.1.1"
-	},
 	"scripts": {
 		"generate": "generate-calypso-package"
 	},

renovate.json5

@@ -10,10 +10,21 @@
 			minimumReleaseAge: '0 days',
 		},
 		{
-			matchDepNames: [ 'node' ],
+			groupName: 'nodejs',
+			matchPackagePatterns: [ '/node$' ],
+			matchDepNames: [ 'node', 'cimg/node' ],
+			matchDatasources: [ 'docker', 'node' ],
 			prPriority: 2,
+		},
+		{
+			groupName: 'nodejs',
+			matchDepNames: [ 'node' ],
 			// This gets published with broader Node support, so we'll update it when needed.
-			ignorePaths: [ 'packages/eslint-plugin-wpcalypso' ]
+			ignorePaths: [ 'packages/eslint-plugin-wpcalypso' ],
+		},
+		{
+			groupName: 'nodejs',
+			matchDepNames: [ '@types/node' ],
 		},
 		{
 			extends: [ 'monorepo:react', ':widenPeerDependencies' ],
@@ -73,6 +84,12 @@
 			depNameTemplate: 'renovate',
 			packageNameTemplate: 'ghcr.io/renovatebot/renovate',
 		},
+		{
+			fileMatch: [ '^Dockerfile$' ],
+			matchStrings: [ 'ARG node_version=(?<currentValue>.*?)\\n' ],
+			depNameTemplate: 'node',
+			datasourceTemplate: 'node',
+		},
 	],
 
 	// --- Update & schedule settings ---

test/e2e/README.md

@@ -23,10 +23,9 @@ Automated end-to-end acceptance tests for the [wp-calypso](https://github.com/Au
 
 Calypso E2E requires the following:
 
-- [NodeJS 18.13.0](https://nodejs.org/en/blog/release/v16.17.0/) or higher
-- [TypeScript 4.5](https://www.staging-typescript.org/docs/handbook/release-notes/typescript-4-5.html) or higher
-- [Playwright 1.28](https://playwright.dev/docs/release-notes#version-128) or higher
-- [yarn 3.1](https://github.com/yarnpkg/berry) or higher
+- [NodeJS](https://nodejs.org/) at the version in the root package.json "engines" field. (Typically latest LTS.)
+- The [yarn](https://github.com/yarnpkg/berry) version available in the repo.
+- Dependencies such as [Typescript](https://typescript.org) and [Playwright](https://playwright.dev) are installed via yarn, and you can find information about the versions we use in ./package.json.
 
 ## Quick start