NotificationSettings: Improve omit logic in header.jsx

Automattic · Dec 13, 2018 · 1bfdf87 · 1bfdf87
1 parent 95c6bbf
commit 1bfdf87
Showing 1 changed file with 8 additions and 11 deletions.
diff --git a/client/me/notification-settings/blogs-settings/header.jsx b/client/me/notification-settings/blogs-settings/header.jsx
@@ -45,17 +45,14 @@ class BlogSettingsHeader extends PureComponent {
 
 	getLegend = () => {
 		const { settings } = this.props;
-
-		// Ignore blog_id, email.achievement and devices (we'll handle devices separately).
-		const filteredSettings = {
-			...omit( settings, [ 'blog_id', 'devices' ] ),
-			email: omit( get( settings, 'email', {} ), [
-				'achievement',
-				'store_order',
-				'scheduled_publicize',
-			] ),
-			timeline: omit( get( settings, 'timeline', {} ), 'store_order' ),
-		};
+		const filteredSettings = omit( settings, [
+			'blog_id',
+			'devices',
+			'email.achievement',
+			'email.store_order',
+			'email.scheduled_publicize',
+			'timeline.store_order',
+		] );
 		// Ignore the device_id of each device found.
 		const devicesSettings = map( settings.devices, device => omit( device, 'device_id' ) );
 		const { true: onCount, false: offCount } = countBy(