Add a couple APIs to return site home url and timezone info#1147
Merged
crazytonyli merged 1 commit intotrunkfrom Feb 4, 2026
Merged
Add a couple APIs to return site home url and timezone info#1147crazytonyli merged 1 commit intotrunkfrom
crazytonyli merged 1 commit intotrunkfrom
Conversation
jkmassel
approved these changes
Feb 4, 2026
jkmassel
reviewed
Feb 4, 2026
| } | ||
|
|
||
| /// Returns the site home URL as a string. | ||
| pub fn home_url_string(&self) -> String { |
Contributor
There was a problem hiding this comment.
I wonder if it would be worthwhile to have a ParsedUrl variant of this that's guaranteed to be a valid URL?
Not a blocker, just for your consideration.
Contributor
Author
There was a problem hiding this comment.
I think it's okay both ways. For the specific case of how I plan to use the new API in the app, I don't plan to parse it: the original value is stored and they will be parsed at different places where it's used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to wordpress-mobile/WordPress-iOS#25183. These info will be used to populate the
Blog.optionsin the app.