Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPCS: Fix phpunit files #995

Merged
merged 2 commits into from
Nov 15, 2024
Merged

PHPCS: Fix phpunit files #995

merged 2 commits into from
Nov 15, 2024

Conversation

obenland
Copy link
Member

Proposed changes:

  • Fixes to remove /tests from the phpcs ignore list.

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

Tests passing should be enough.

@obenland obenland added php Pull requests that update Php code [Type] Janitorial labels Nov 15, 2024
@obenland obenland self-assigned this Nov 15, 2024
@pfefferle
Copy link
Member

I will merge this, because I need to work on Unit-Tests.

@pfefferle pfefferle merged commit 5ab5659 into trunk Nov 15, 2024
22 of 23 checks passed
@pfefferle pfefferle deleted the update/phpcs-tests branch November 15, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfefferle pfefferle pfefferle approved these changes

Assignees

@obenland obenland

Labels
php Pull requests that update Php code [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obenland @pfefferle