Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Fix styles to align with rest of wp-admin #992

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

obenland
Copy link
Member

Fixes the display of update nags and brings the font size of the settings heading en par with other wp-admin screens.

Proposed changes:

  • Adds margins for update nag.
  • Adds heading styles for settings title.

Other information:

Before After
Screenshot 2024-11-13 at 8 34 31 PM Screenshot 2024-11-13 at 5 26 15 PM

Testing instructions:

  • Visit the settings page on a WP install with a pending Core update.
  • Make sure the nag has proper margins.
  • Navigate to Privacy settings page.
  • Make sure the title font sizes are the same between the two screens.

@obenland obenland self-assigned this Nov 14, 2024
Copy link
Member

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't even see the difference 🫣

@obenland
Copy link
Member Author

It's subtle. If you open the screenshots in new tabs and switch between them, at least the banner should be easier to see.

@obenland obenland merged commit 317dc9b into trunk Nov 14, 2024
21 checks passed
@obenland obenland deleted the fix/settings-heading branch November 14, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants