Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show '⁂ Fediverse Preview' link in Row-Actions #989

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

pfefferle
Copy link
Member

@pfefferle pfefferle commented Nov 13, 2024

Screenshot 2024-11-13 at 13 09 46

@obenland
Copy link
Member

I'm not sure I'd understand that that's meant to be an Activitypub Preview, until a few days ago I was unaware of the logo. Is this something other plugins offer as well in the list view?

@pfefferle
Copy link
Member Author

Good question... The icon is still pretty new... 🤔

I thought it might be nice to be as short as possible... do you think it should be ⁂ Fediverse Preview instead? at least until people might recognize the icon...

@pfefferle pfefferle changed the title Show '⁂ Preview' link in Row-Actions Show '⁂ Fediverse Preview' link in Row-Actions Nov 13, 2024
@obenland
Copy link
Member

My preview looks like this, is that a configuration issue?

Screenshot 2024-11-14 at 10 13 59 AM

@obenland
Copy link
Member

It's not part of this PR but would be a good follow up, the preview link looks off with the Core preview:

image

@pfefferle
Copy link
Member Author

It's not part of this PR but would be a good follow up, the preview link looks off with the Core preview

I saw this is already reported somewhere in the core-editor repo, but can't find it any more. The "Preview in new tab" seems to be not aligned with the top links and the fediverse links. I am not sure if we can do something there.

@pfefferle
Copy link
Member Author

My preview looks like this, is that a configuration issue?

How have you done that!?! 😱

@obenland
Copy link
Member

I personally don't think a preview link is necessary in the list view. It makes more sense to me where it is now, in the Preview dropdown when editing a post.

@pfefferle
Copy link
Member Author

We had some feedbacks from people with the classic editor, that they can't use it now and because the list also includes the classic preview link...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants