New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPCS: Enable CommentedOutCode sniff #914

Merged

pfefferle merged 1 commit into trunk from fix/CommentedOutCode-sniff

Sep 30, 2024

Member

obenland commented Sep 29, 2024

Proposed changes:

Adds inline ignores for the two exceptions introduced in It seems that Mastodon has issues with HTML in summaries #893.
Updates comment to make it not appear as commented out code (Could probably be removed, too. Function docs cover possible return types).
Removes sniff exception.

See #905.


          PHPCS: Enable CommentedOutCode sniff

obenland added php [Type] Janitorial labels

obenland requested review from pfefferle and mattwiebe

September 29, 2024 23:15

obenland self-assigned this

pfefferle approved these changes

View reviewed changes

pfefferle merged commit 7112177 into trunk

22 checks passed

pfefferle deleted the fix/CommentedOutCode-sniff branch

September 30, 2024 10:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

php [Type] Janitorial