Header Images: fix cropping for users without the 'customize' capability #854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I found a Core bug here. There's absolutely no reason for the ajax request to include
wp_customize=on
, the logic is entirely handled in thewp_ajax_crop_image()
handler.This commit appears to have moved the logic from the Customizer into a more general purpose context while leaving the constraining
wp_customize=on
parameter.I guess this could be a core patch
Fixes #846
Proposed changes:
Make a custom controller but without
wp_customize=on
Other information:
Testing instructions: