Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .htaccess issue with subdomain #433

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Conversation

edent
Copy link
Contributor

@edent edent commented Sep 14, 2023

Fixes #419

Proposed changes:

  • Blogs in subdirectories didn't work with the previous .htaccess rule

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Create a blog in a subdirectory - for example example.com/blog/
  • Try to use the original .htaccess file
  • Note that visiting https://example.com/.well-known/webfinger gets redirected to https://blog///.well-knownwebfinger
  • Try this new, improved, organic, fat free, low-sugar .htaccess file
  • Rejoice as you are redirected correctly.

Copy link
Member

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pfefferle pfefferle merged commit f7ebced into Automattic:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.htaccess instructions not working?
2 participants