Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Follow Me" block #395

Merged
merged 29 commits into from
Aug 30, 2023
Merged

Add "Follow Me" block #395

merged 29 commits into from
Aug 30, 2023

Conversation

mattwiebe
Copy link
Contributor

This will add a "Follow Me" block that will produce a dialog for educating and enabling fab fediverse following!

Screenshot 2023-08-11 at 12 32 23 Screenshot 2023-08-11 at 12 33 44

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Go to '..'

@mattwiebe mattwiebe requested a review from pfefferle August 11, 2023 17:34
@mattwiebe mattwiebe mentioned this pull request Aug 11, 2023
@mattwiebe mattwiebe marked this pull request as ready for review August 17, 2023 01:49
@mattwiebe
Copy link
Contributor Author

I'd like to figure out what's going on with those phpcs CI builds, I can't replicate those errors locally at all with composer run lint which is theoretically running the same command

@mattwiebe
Copy link
Contributor Author

I can't replicate those errors locally at all

I just needed to rm -rf vendor && composer install - something had gone wrong in my local install. Now added a composer run lint:fix command to call phpcbf

@mattwiebe
Copy link
Contributor Author

This is pretty close to ready now?

We are abusing the Link color to set the button color. Otherwise there's no really good way to set it.

pfefferle
pfefferle previously approved these changes Aug 30, 2023
Copy link
Member

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@pfefferle
Copy link
Member

Can you also update the changelog?!?

@mattwiebe
Copy link
Contributor Author

dce6daa - it looks a bit busier because I picked a consistent "no periods" style. :)

@mattwiebe mattwiebe merged commit 7aea1e8 into master Aug 30, 2023
@mattwiebe mattwiebe deleted the add/follow-me-block branch August 30, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants