Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: load plugin later. #376

Merged
merged 1 commit into from
Jul 27, 2023
Merged

General: load plugin later. #376

merged 1 commit into from
Jul 27, 2023

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jul 27, 2023

Fixes #375

Proposed changes:

Let's try to load the plugin later in the WP lifecycle to avoid the Fatals happening in #375.

Related discussion: p1690454109597069-slack-C04TJ8P900J

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Is CI happy?
  • Can you use the plugin on a multisite install with no errors?
  • Can you visit wp-admin, frontend, and activitypub requests without any issues?

@pfefferle @jeherve
General: load plugin faster
109b945 
Fixes #375

Related discussion: p1690454109597069-slack-C04TJ8P900J
@jeherve jeherve added the [Type] Bug Something isn't working label Jul 27, 2023
@jeherve jeherve requested a review from pfefferle July 27, 2023 12:55
@jeherve jeherve self-assigned this Jul 27, 2023
pfefferle
pfefferle approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit-Test seem to be green. Let's give it a try!

@pfefferle pfefferle merged commit ca5a3e2 into master Jul 27, 2023
@pfefferle pfefferle deleted the fix/loading-order-rest branch July 27, 2023 13:00
mattwiebe added a commit that referenced this pull request Jul 27, 2023
@mattwiebe
Ensure everything is loaded properly after #376
0d605c6 
Also fixes an spl_autoload bug
pfefferle pushed a commit that referenced this pull request Jul 27, 2023
@mattwiebe
Ensure everything is loaded properly after #376 (#378)
f49e15b 
Also fixes an spl_autoload bug
pfefferle added a commit that referenced this pull request Aug 10, 2023
@jeherve @pfefferle
General: load plugin faster (#376)
b83c8fa 
Fixes #375

Related discussion: p1690454109597069-slack-C04TJ8P900J

Co-authored-by: Matthias Pfefferle <pfefferle@users.noreply.github.com>
pfefferle pushed a commit that referenced this pull request Aug 10, 2023
@mattwiebe @pfefferle
Ensure everything is loaded properly after #376 (#378)
1c7ab2c 
Also fixes an spl_autoload bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfefferle pfefferle pfefferle approved these changes

Assignees

@jeherve jeherve

Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REST namespace: fatal error
2 participants
@jeherve @pfefferle