Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include @mentions in the JSON representation of the reply #1086

Merged
merged 15 commits into from
Dec 19, 2024
Merged

Include @mentions in the JSON representation of the reply #1086

merged 15 commits into from
Dec 19, 2024

Conversation

pfefferle
Copy link
Member

@pfefferle pfefferle commented Dec 17, 2024 •
edited
Loading

Fix #844

When clicking reply to reply to a comment added via Federation, it would be nice if the handle of the person you're replying to, and maybe even the handles of the all the people @-mentioned in the comment you're replying to, were added to the JSON representation of the reply.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Go to '..'

@pfefferle pfefferle self-assigned this Dec 17, 2024
@pfefferle pfefferle marked this pull request as ready for review December 18, 2024 09:14
obenland
obenland reviewed Dec 18, 2024
View reviewed changes
includes/transformer/class-comment.php Outdated Show resolved Hide resolved
includes/transformer/class-comment.php Outdated Show resolved Hide resolved
tests/includes/transformer/class-test-comment.php Show resolved Hide resolved
@pfefferle pfefferle requested review from obenland and a team December 19, 2024 08:52
obenland
obenland previously approved these changes Dec 19, 2024
View reviewed changes
@pfefferle pfefferle merged commit 56308cd into trunk Dec 19, 2024
22 checks passed
@pfefferle pfefferle deleted the implement/844 branch December 19, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obenland obenland obenland left review comments

Assignees

@pfefferle pfefferle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comment replies via Federation: include @mentions in the JSON representation of the reply
2 participants
@pfefferle @obenland