Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Missing attachement-type for enclosures #1021

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Conversation

pfefferle
Copy link
Member

@mattwiebe this should fix the broken attachment, but not that it is added twice.

#1020

@pfefferle pfefferle requested review from a team and mattwiebe November 26, 2024 09:38
@mattwiebe
Copy link
Contributor

This did not fix my issue on wpcom. It seems like the problem only happens there, so I have a workaround.

This PR looks like good defensiveness though

mattwiebe
mattwiebe previously approved these changes Nov 27, 2024
Copy link
Contributor

@mattwiebe mattwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pfefferle pfefferle merged commit f1244e7 into trunk Nov 27, 2024
15 checks passed
@pfefferle pfefferle deleted the fix/enclosure branch November 27, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants