Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy image, because otherwise it will be deleted. #1005

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

pfefferle
Copy link
Member

The sideload logic of WordPress deletes the source file and that might cause issues in local tests. This change generates a copy of the image to use that in tests.

The sideload logic of WordPress deletes the source file and that might cause issues in local tests. This change generates a copy of the image to use that in tests.
@pfefferle pfefferle requested a review from akirk November 20, 2024 09:22
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, sorry!

@pfefferle pfefferle merged commit 4727fd2 into trunk Nov 20, 2024
21 checks passed
@pfefferle pfefferle deleted the improve/image-parser-tests branch November 20, 2024 11:25
@pfefferle
Copy link
Member Author

No problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants