Add payment activity widget emoji survey #8506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +1.56 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
11 tasks
Manual testing✅ - Survey appears in CardFooter as expected. 
✅ - Text box prompting for reason appears for the lowest three ratings I am not sure if this has got something to do with my local setup. The summary report of the answers also shows some additional rows without labels.
|
|
Thanks @nagpai 🙌
I also see these warnings, but also on other https://dev-mc.a8c.com/marketing/survey/ screens unrelated to this PR. I'll investigate to see if they are being introduced by this PR. Update: Confirmed that these are harmless warnings and not introduced by this PR. Comparing another survey results page on dev-mc shows the same warnings, but mc works without warnings or problems. ✅
Yes this is caused by test data that was added during development of this feature. We could clean up the |
Thanks so much for checking this! Glad to know it wasn't my setup. Indeed I did see the same warnings with other surveys too, when I checked. 👍 I will do a round of code review today. |
nagpai
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Great PR @Jinksi 🎉 , looks good to me. Left some comments none of which are blocker for the merge.
Ps: There are some conflicts after merging the data PR.
|
|
||
| type ContextValue = ReturnType< typeof useContextValue >; | ||
|
|
||
| const WcPayOverviewSurveyContext = createContext< ContextValue | null >( null ); |
There was a problem hiding this comment.
Love the implementation 🙌 though I am curious about the use of context for this feature, would love to know your thought process here.
There was a problem hiding this comment.
This was all carried over from the previous PR #8309. My thought process is that the Context approach works well, so there is no need to change it 😆
Jinksi
changed the title
|
Investigating failing GH checks...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8485
Note
Based on @dpaun1985's PR #8309 – commits have been cherry-picked to this branch.
Changes proposed in this Pull Request
Emoji-based survey component to capture the user sentiment for the new Payments Overview Widget.
The survey accepts 3 fields:
rating: 'very-unhappy', 'unhappy', 'neutral', 'happy', 'very-happy'comments: user-defined textwcpay-version: WooPayments plugin version as text (e.g.7.4.0)iOS screenshots
Todo
Testing instructions
wp option update _wcpay_feature_payment_overview_widget 1in CLI (npm run cliif docker)public-api.wordpress.comanddev-mc.a8c.comto your sandbox's IP address if you didn't alreadyarc patch D140691)Payments -> Overviewwp option delete wcpay_survey_payment_overview_submittedto clear your local submission stateMJ5lCh.mp4
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge