Add settings object for every gateway #8414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
This reverts commit 98cc737.
timur27
force-pushed
the
fix/payment-methods-rendering
branch
2 times, most recently
from
1d44619
to
a7f9ff1
Compare
gpressutto5
approved these changes
Mar 18, 2024
Jinksi
pushed a commit
that referenced
this pull request
Mar 28, 2024
Co-authored-by: Timur Karimov <timurkarimov@timurs-macbook-pro.home>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8370
Changes proposed in this Pull Request
This PR adds setting objects for every gateway, because after #8361 those are expected to exist. This PR makes sure that main gateway settings (
upe_enabled_payment_method_ids) are synchronized with the rest. Also, theenableflag for every gateway should now reflect the real status of the gateway.Testing instructions
Settings screen
WooCommerce -> Settings -> Paymentsand then enable back again: confirm that the enabled payment method list didn't changeMigration script testing with WooPayments
7.3.0on the JN site7.3.0Savesettingsnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge