Add correct TS interface for charge.dispute
#7311
Draft
+20
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Jinksi
added
type: task
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
Is that the only difference between the two types? Are they two variations of the same type ("Dispute") or are they distinct types? At first glance, I'd look at two options:
Curious where the difference comes from too. Is this how Stripe structures this data (and it transparently passes through WCPay Server), or is this defined in our local data structures? |
Yes, the dispute that is part of the This is due to our use of Stripe's 
This is the current situation ( I'd prefer us to aim for accurate TS interfaces so we can trust and rely on them and not have to find workarounds for them (e.g.
This could be the best solution, and we can introduce this change server-side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Our interfaces for Disputes are not 100% accurate:
charge.dispute.charge: stringdispute.charge: ChargeCurrently, we use
Disputeas the interface for both of these response types.This PR introduces a
ChargeDisputeinterface forcharge.disputeobjects.Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge