Open
Description
openedon Mar 21, 2024
Description
This is a follow up to #8415 where there are some issues reported by phpcs that were not a straight-forward fix.
Running
./vendor/bin/phpcs --standard=phpcs.xml.dist $(git ls-files | grep '.php$') --sniffs='VariableAnalysis.CodeAnalysis.VariableAnalysis'Results in a list of issues in these files (also a command to get just the list of files)
./vendor/bin/phpcs --standard=phpcs.xml.dist $(git ls-files | grep '.php$') --sniffs='VariableAnalysis.CodeAnalysis.VariableAnalysis' | rg 'FILE' | sed 's/FILE: \/path\/to\/wcpay\/repo\/parent\/woocommerce-payments\//* 'tests/unit/subscriptions/test-class-wc-payments-subscription-service.phptests/unit/subscriptions/test-class-wc-payments-subscriptions-event-handler.phpincludes/payment-methods/class-upe-payment-method.phptests/unit/subscriptions/test-class-wc-payments-subscriptions-migrator.phpincludes/multi-currency/Analytics.phpincludes/multi-currency/FrontendCurrencies.phptests/unit/test-class-compatibility-service.phpsrc/Internal/Payment/State/AbstractPaymentState.phptests/unit/multi-currency/test-class-multi-currency.phptests/unit/test-class-wc-payments-features.phptests/unit/helpers/class-wc-helper-product-add-ons-helper.phpincludes/class-wc-payments-incentives-service.phptests/unit/test-class-wc-payment-gateway-wcpay-payment-types.phptests/unit/core/server/request/test-trait-order-info.phptests/unit/helpers/class-wc-helper-subscriptions-synchroniser.phptests/unit/multi-currency/compatibility/test-class-woocommerce-subscriptions.phpincludes/class-logger.phpincludes/multi-currency/MultiCurrency.phptests/unit/multi-currency/test-class-analytics.phptests/unit/test-class-wc-payment-gateway-wcpay-process-payment.phpincludes/wc-payment-api/class-wc-payments-api-client.phpincludes/admin/class-wc-payments-admin-sections-overwrite.phptests/unit/subscriptions/test-class-wc-payments-invoice-service.phptests/unit/test-class-wc-payment-gateway-wcpay-subscriptions-payment-method-order-note.phptests/unit/subscriptions/test-class-wc-payments-subscription-change-payment-method.phptests/unit/test-class-wc-payment-gateway-wcpay-subscriptions-process-payment.phptests/unit/test-class-wc-payments-utils.phptests/unit/test-class-wc-payment-gateway-wcpay-subscriptions.phpincludes/class-wc-payments-webhook-processing-service.phpincludes/class-wc-payments.phpincludes/class-wc-payments-apple-pay-registration.phptests/unit/test-class-wc-payment-gateway-wcpay.php
These seem to be mostly valid cases. I'd love to see if we can maybe add some rule to phpcs.xml.dist that catches these valid cases, e.g. in filters and hooks.
Alternatively we could just ignore these outright. Either way we should go through all of these issues and either:
- Fix the issue, if it exists;
- Add ignores in-place via comments; or
- Add an ignore to
phpcs.xml.dist.
Acceptance criteria
No more issues reported by phpcs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment