Merge branch 'develop' into fix/8232-deprecated-strtolower-on-order-r…

…eceived-page
Automattic · Mar 18, 2024 · 0819154 · 0819154
2 parents 3f93b1f + f15c223
commit 0819154
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/changelog/payment-utils-when-amount-too-large b/changelog/payment-utils-when-amount-too-large
@@ -0,0 +1,4 @@
+Significance: patch
+Type: fix
+
+fix: better error message when saved card and amount too large
diff --git a/changelog/refactor-validator-bundle-size b/changelog/refactor-validator-bundle-size
@@ -0,0 +1,4 @@
+Significance: patch
+Type: dev
+
+refactor: validator package bundle size improvements
diff --git a/client/checkout/woopay/express-button/use-express-checkout-product-handler.js b/client/checkout/woopay/express-button/use-express-checkout-product-handler.js
@@ -1,7 +1,7 @@
 /**
  * External dependencies
  */
-import validator from 'validator';
+import isEmail from 'validator/lib/isEmail';
 import { __ } from '@wordpress/i18n';
 
 const useExpressCheckoutProductHandler = ( api ) => {
@@ -49,7 +49,7 @@ const useExpressCheckoutProductHandler = ( api ) => {
 			if (
 				! data.wc_gc_giftcard_to_multiple
 					.split( ',' )
-					.every( ( email ) => validator.isEmail( email.trim() ) )
+					.every( ( email ) => isEmail( email.trim() ) )
 			) {
 				alert(
 					__(
@@ -62,7 +62,7 @@ const useExpressCheckoutProductHandler = ( api ) => {
 		}
 
 		if ( data.hasOwnProperty( 'wc_gc_giftcard_to' ) ) {
-			if ( ! validator.isEmail( data.wc_gc_giftcard_to ) ) {
+			if ( ! isEmail( data.wc_gc_giftcard_to ) ) {
 				alert(
 					__(
 						'Please type only valid emails',

diff --git a/includes/class-wc-payments-utils.php b/includes/class-wc-payments-utils.php
@@ -572,6 +572,8 @@ public static function get_filtered_error_message( Exception $e ) {
 				),
 				wp_strip_all_tags( html_entity_decode( $price ) )
 			);
+		} elseif ( $e instanceof API_Exception && 'amount_too_large' === $e->get_error_code() ) {
+			$error_message = $e->getMessage();
 		} elseif ( $e instanceof API_Exception && 'wcpay_bad_request' === $e->get_error_code() ) {
 			$error_message = __( 'We\'re not able to process this request. Please refresh the page and try again.', 'woocommerce-payments' );
 		} elseif ( $e instanceof API_Exception && ! empty( $e->get_error_type() ) && 'card_error' !== $e->get_error_type() ) {