Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix a problem with E2E tests #376

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

gudmdharalds
Copy link
Contributor

@gudmdharalds gudmdharalds commented Sep 26, 2023

This pull request attempts to resolve a problem sometimes encountered when running E2E tests (probably when not on a pull request branch, see example). With the added reference, there should hopefully always be a branch available when checking out.

TODO:

  • Added patch for E2E test checkout
  • [N/A] Add/update tests -- unit/integrated/E2E (if needed)
    • [N/A] Ensure only one function/functionality is tested per test file.
  • [N/A] Add to, or update, Scan run detail report as applicable
  • Check status of automated tests
  • [N/A] Ensure PHPDoc comments are up to date for functions added or altered
  • Assign appropriate priority and type of change labels.
  • Changelog entry (for VIP) [ Add changelog for version 1.3.9 #377 ]

Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved pull request #376 as it contains only auto-approvable files -- non-functional changes to PHP files or file-types that are auto-approvable (css, csv, eot, gif, gz, ico, ini, jpeg, jpg, json, less, map, md, mdown, mo, mp4, otf, pcss, pdf, po, pot, png, sass, scss, styl, ttf, txt, woff, woff2, yml).

@gudmdharalds gudmdharalds merged commit 056ed03 into trunk Sep 27, 2023
10 checks passed
@gudmdharalds gudmdharalds deleted the update/tools-e2e-etc branch September 27, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants