Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display "No issues were found...." when maximum number of comments is reached #325

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Do not display "No issues were found...." when maximum number of comments is reached #325

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8240886
Record we submitted feedback to GitHub when maximum comments is reached
gudmdharalds Oct 25, 2022
55cec7c
Update comment
gudmdharalds Oct 25, 2022
1eaf7b0
Check if feedback was internally registered as applicable.
gudmdharalds Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Record we submitted feedback to GitHub when maximum comments is reached
  • Loading branch information
@gudmdharalds
gudmdharalds committed Oct 25, 2022
commit 82408865b55f926868ffccf49d01762c3743af38
8 changes: 8 additions & 0 deletions main.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2689,6 +2689,14 @@ function vipgoci_run_scan_total_comments_max_warning_post(
VIPGOCI_REVIEW_COMMENTS_TOTAL_MAX,
$options['commit']
);

// Record that we submitted feedback to GitHub.
vipgoci_report_feedback_to_github_was_submitted(
$options['repo-owner'],
$options['repo-name'],
$pr_number,
true
);
}
}
}
Expand Down