-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add allow list for file filtering function #289
Conversation
…re. This means only folders mentioned will be included, and the rest will be skipped
… Also add tests for actually testing this logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phpcs scanning turned up:
🚫 3 errors
This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.
Scan run detail
Software versions
Options file (
|
PHP lint optionsPHP lint files enabled:
Lint modified files only:
Directories not PHP linted:
SVG configurationSVG scanning enabled:
Auto-approval configurationAuto-approvals enabled:
Non-functional changes auto-approved:
Auto-approved file-types:
|
PHPCS configurationPHPCS scanning enabled:
PHPCS severity level:
Standard(s) used:
Runtime set:
Custom sniffs included:
Custom sniffs excluded:
Directories not PHPCS scanned:
|
Dismissing review as all inline comments are obsolete by now
No issues were found to report when scanning latest commit (commit-ID: 590a6bf) This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation. Scan run detail
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is meant to add the ability to pass an allow list for file filtering. This means that:
allow list -> node_modules
So any file that is NOT in the node_modules folder will be filtered. Only the node_modules files will be allowed.
This introduces a new option that has to be passed in called include_folders. There's no other change outside this function, so it's not exposed within the cli.
TODO: